Registry Service breaks at client side if Registry Server Password includes special char '@'

[3amroSalem]

Overview of the issue

Setting ${jhipster.registry.password} with passwords that includes'@' results in java.lang.IllegalArgumentException: Host name may not be null at client side.

That's really might be a eureka configuration issue not, Jhipster issue, how ever exception message was misleading and time consuming trying to figure out the root cause for this.

Motivation for or Use Case

Allowing special char @ in Jhipster Registry Password

Reproduce the error

Set Jhipster Registry password with char '@' then try to configure client which will fail cause,
FQN will be including @ twice for example https://admin:123@[email protected]/eureka/

Related issues

Suggest a Fix

Open for suggestions, might be a restricting passwords not to include '@' ?
Or may be just close this and report to Eureka :D

JHipster Version(s)

v3.2.4

Browsers and Operating System

• [*] Checking this box is mandatory (this is just to show you read everything)

[3amroSalem]

A friend suggested to encode special characters like that before passing them as part of the URL, so @ would need to be passed as %40, etc, may be that can be automated from client.

[jdubois]

Oh yes, the login:password must probably by urlencoded or something similar - that's definitely an issue!

[PierreBesson]

As it is used for basic auth in admin:[email protected] yes the password needs to be url encoded. However I dont' think we could endode it transparently for the user. We should just add a comment to make it explicit that the registry password should be encoded.

[jdubois]

I tried to find some documentation about this, but couldn't find any :-(
So that's "normal" for basic authentication, but I don't know how it's supposed to be encoded.

[PierreBesson]

@jdubois The encoding needed is regular base64 encoding of "user:password", see the spec at : https://tools.ietf.org/html/rfc7617#section-2

[jdubois]

Great thanks! Let's just document that