Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Allow anonymous user to generate an application via user interface #162

Closed
vishal423 opened this issue May 13, 2020 · 12 comments · Fixed by #301
Closed

Allow anonymous user to generate an application via user interface #162

vishal423 opened this issue May 13, 2020 · 12 comments · Fixed by #301
Labels
$$ bug-bounty $$ https://www.jhipster.tech/bug-bounties/ Good First Issue Good as a startring point of contributions to this repo Type: Enhancement 🚀 Something that modifies or adds to existing functionality $200 https://www.jhipster.tech/bug-bounties/

Comments

@vishal423
Copy link
Contributor

Should be done after #160
@SudharakaP
Copy link
Member

Since #160 is done I am closing this.

@vishal423
Copy link
Contributor Author

It was meant to be worked upon after the merge :)

@vishal423 vishal423 reopened this Jun 2, 2020
@SudharakaP
Copy link
Member

SudharakaP commented Jun 2, 2020 •
edited
Loading

@vishal423 : Ops sorry. I think I closed this and #161 with the idea the changes are already incorporated in the update.

@SudharakaP SudharakaP added the Type: Enhancement 🚀 Something that modifies or adds to existing functionality label Jun 18, 2020
@SudharakaP SudharakaP added the Good First Issue Good as a startring point of contributions to this repo label Jul 22, 2020
@swarajsaaj
Copy link
Contributor

I feel this would be very nice to have. @SudharakaP @vishal423 Shall I pick this up if no one is working on it?

@vishal423
Copy link
Contributor Author

Feel free to pick up @swarajsaaj

@vishal423
Copy link
Contributor Author

@deepu105 @pascalgrimaud @mraible - It seems a good candidate to have a bounty. Can you add one ?

@pascalgrimaud pascalgrimaud added $$ bug-bounty $$ https://www.jhipster.tech/bug-bounties/ $200 https://www.jhipster.tech/bug-bounties/ labels May 29, 2021
@swarajsaaj
Copy link
Contributor

swarajsaaj commented May 29, 2021 •
edited
Loading

Thanks @vishal423 ,Shall we also move this to homepage once we make it for anonymous users (like https://start.spring.io/, https://code.quarkus.io/ or https://code.quarkus.io, maybe with a refactored interface too). Any views on this @pascalgrimaud @vishal423 @SudharakaP ?

@pascalgrimaud
Copy link
Member

@vishal423 : done

@SudharakaP
Copy link
Member

SudharakaP commented May 29, 2021 •
edited
Loading

Thanks @vishal423 ,Shall we also move this to homepage once we make it for anonymous users (like https://start.spring.io/, https://code.quarkus.io/ or https://code.quarkus.io, maybe with a refactored interface too). Any views on this @pascalgrimaud @vishal423 @SudharakaP ?

@swarajsaaj : Thanks for taking it up @swarajsaaj. My suggestion is that as an MVP first let us just open it up for anonymous users. Changing the interface can be done on a separate issue. 😄

swarajsaaj added a commit to swarajsaaj/jhipster-online that referenced this issue May 29, 2021
@swarajsaaj
Allow anonymous users to download zipfile
adc24ee 
Remove security on "/download-application" and refactor user-interface
to allow non-logged in users to generate and download the zip file.

Fix jhipster#162
@swarajsaaj swarajsaaj mentioned this issue May 29, 2021
Merged
SudharakaP pushed a commit that referenced this issue Jun 5, 2021
@swarajsaaj
Allow anonymous users to download zipfile (#301)
fbbe5b1 
Remove security on "/download-application" and refactor user-interface
to allow non-logged in users to generate and download the zip file.

Fix #162
@vishal423
Copy link
Contributor Author

Can we add a section / link on the main page to navigate to the UI interface to allow anonymous users to generate applications?

@swarajsaaj
Copy link
Contributor

@vishal423 The "Create Application" link in the left navigation bar is now available for anonymous users. Do you mean something on the right section too?

@vishal423
Copy link
Contributor Author

@swarajsaaj thanks for the confirmation. It seems a caching issue on my side. I can see the option now and looks good to me.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Assignees
No one assigned
Labels
$$ bug-bounty $$ https://www.jhipster.tech/bug-bounties/ Good First Issue Good as a startring point of contributions to this repo Type: Enhancement 🚀 Something that modifies or adds to existing functionality $200 https://www.jhipster.tech/bug-bounties/
Projects
None yet
Milestone
No milestone
Development

Successfully merging a pull request may close this issue.

Allow anonymous users to download zipfile swarajsaaj/jhipster-online
4 participants
@swarajsaaj @pascalgrimaud @SudharakaP @vishal423