Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

CTG Not Valid Start Codon #8

Open
PhageGuy opened this issue Oct 18, 2017 · 10 comments
Open

CTG Not Valid Start Codon #8

PhageGuy opened this issue Oct 18, 2017 · 10 comments

Comments

@PhageGuy
Copy link
Contributor

Hi all,

In my database some of the genomes use CTG as their start codon. This appears to not be a valid start codon in PhamDB. Is there any way I can edit the parameters of acceptable start codons to include CTG so I can add these phages to the database?

Thanks!
@jglamine
Copy link
Owner

Hi, thanks for reporting this issue.

I'm not actively developing PhamDB at this point, but if you want to submit a pull request I'd be happy to merge it.

The relevant line of code to change would be here:

https://github.com/jglamine/phamdb/blob/master/pham/genbank.py#L531

I'm not sure what the implications are in terms of adding that as a default start codon - would this cause problems for people who don't want CTG as a start codon?

Another work around would be to not use CTG as your start codon, but I'm aware that this isn't really helpful advice.

@PhageGuy
Copy link
Contributor Author

Thanks for the response!

If I were to change the code would the change be implemented immediately, or would I have to redownload docker or something along those lines? Also, I believe that any organism that doesn't aim to have CTG as a start simply wouldn't. Start codons are highly conserved so I couldn't see a situation where someone who doesn't already want to use CTG would have an organism who's start is CTG and then gets through the filter via this change.

Thanks again

@jglamine
Copy link
Owner

jglamine commented Oct 18, 2017 via email

@PhageGuy
Copy link
Contributor Author

Ok great!

So being I am a biologist rather than a computer scientist what if anything would I need to do for you so that the code can be changed to allow CTG as a valid start?

Thanks again for your help!

@jglamine
Copy link
Owner

Sorry for the late reply! Unfortunately I don't have a lot of free time to help walk you through the steps.

If there's someone in your organization who is familiar with computer science or software development, you might want to ask them for help. They'll need to know about git and Github at a minimum, and knowledge of Python and Docker would also be useful.

@PhageGuy
Copy link
Contributor Author

PhageGuy commented Nov 8, 2017

Hi jglamine,

Just bumping on the issue thread as well that I made the merge request so that the docker image can be published with CTG.

Thanks!

@jglamine
Copy link
Owner

jglamine commented Nov 9, 2017 via email

@PhageGuy
Copy link
Contributor Author

PhageGuy commented Nov 9, 2017 via email

@PhageGuy
Copy link
Contributor Author

Good evening, just bumping for the merge request with CTG to complete our database

Thanks!

@jglamine
Copy link
Owner

I've merged you change, but I'm running into a bunch of errors trying to publish a new image - it's been two years, so some stuff which used to work doesn't anymore. I'd love to help, but I don't really have the time or energy to work through these issues.

My advice is to find a workaround, perhaps by editing your genbank files or using legacy phamerator without phamdb.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

No branches or pull requests
2 participants
@jglamine @PhageGuy