Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

[ansible/xray] "Import CentOS GPG public key" hardcoded URL #413

Closed
gianluca-fiasco opened this issue Oct 17, 2024 · 1 comment
Closed
Labels
enhancement New feature or request

Comments

@gianluca-fiasco
Copy link

Is this a BUG REPORT or FEATURE REQUEST? (choose one): Bug

Which installer:
Ansible

Which product and version (eg: ansible & collection version - 7.24.2):
Ansible collection multiple versions

Which operating system and version(eg: ubuntu & version - 20.4):
RHEL8

Which product license (Enterprise/Pro):
Enterprise+

What happened:

This task should be customizable, and the URL should not be hardcoded.

The task located at this link:

- name: Import CentOS GPG public key
  become: true
  ansible.builtin.rpm_key:
    key: https://www.centos.org/keys/RPM-GPG-KEY-CentOS-Official
    state: present

has the following issues:

  • It is not idempotent: This task will run every time, regardless of the key’s presence.
  • External URL: The URL points to an external resource, which may violate security policies.

In my company (an S&P 500 firm with 30,000 employees), we are not permitted to retrieve files from the internet. Ideally, this key should be fetched from an internal server or hosted on Artifactory itself.

@chukka
Copy link
Collaborator

chukka commented Nov 18, 2024

@gianluca-fiasco Thanks for raising this issue , Would you mind raising this as a Pull Request, Happy to take this in upcoming releases :)

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
enhancement New feature or request
Projects
None yet
Development

No branches or pull requests

2 participants