Configure tempPath directory

[ojio-san]

Hello,

In config.ts we can see that tempPath is build by using <rundir>/temp/ directory : this directory seems to be used for sending magnets and torrents.

Would it be possible to have a --tempdir or FLOOD_OPTION_tempdir to customize this directory ?

This way, using docker : we will be able to share this directory using volumes.

For example, with a small docker-compose.yml configuration :

flood:
   image: flood
[...]
   environment:
     - FLOOD_OPTION_tempdir=/mnt/tempdir
    volumes:
      - /home/user/shared-torrent-dir:/mnt/tempdir:rw

rtorrent:
   image: rtorrent
[...]
    volumes:
      - /home/user/shared-torrent-dir:/mnt/tempdir:ro

Thank you and have a nice day :)

[jesec]

You can share the entire runtime directory instead.

Anyways, with the implementation of JSON-RPC, I think it is safe now to send raw torrent metadata directly via socket, so there is no need for rTorrent to access Flood's temporary directory. I plan to implement the change in the next minor release. This basically reverts to the pre-4.0 behavior, and, unfortunately, as a result, XMLRPC users may encounter troubles with larger torrents.

On the other hand, the change would eliminate many cases of filesystem access/context issues. It also makes it possible to tighten access control of Flood's runtime directory: https://github.com/jesec/flood/projects/7#card-54370342 .

[ojio-san]

Thank you for your reply :)

Yes, right now I share Flood's <rundir>/temp/ directory to rtorrent, but in my opinion, it feels a bit weird to have this path in rtorrent container.

Anyway, I'm genuinely very happy to see that this project will switch to using XMLRPC implementation for sending torrent/magnets : it feels more 'cloudy' by using the filesystem less. Oh god, I can't wait to use Flood's future release !

Also, it's nice to see that this project is getting more and more 'security measures' : thoses should be more appreciated, and it should be more seen elsewhere. I noticed that at a lot of people thinks that using docker/k8s is just a way to forget about security.

Have a nice day :)