Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Add Laravel 11 support on tests #1261

Merged
merged 11 commits into from
Mar 18, 2024
Merged

Conversation

dfsmania
Copy link
Collaborator

@dfsmania dfsmania commented Mar 16, 2024

Question Answer
Issue or Enhancement Enhancement
License MIT

What's in this PR?

  • Include Laravel 11 and PHP 8.3 on the tests matrix
  • Update checkout and cache actions to v4
  • Improve commentaries on the workflow
  • Improve the upload code coverage step
  • Remove scrutinizer/ocular from dev dependencies, it's instead required in the upload coverage step
  • Fix tests to provide compatibility with Laravel 11

Checklist

  • I tested these changes.

Include **Laravel 11** and **PHP 8.3** on the test matrix
@dfsmania dfsmania marked this pull request as draft March 16, 2024 20:37
Test with old testbench version
Restore to testbench 9.* for Laravel 11
Test with old ocular.phar
Remove ocular form dev dependencies
Test fix on setLaravelSession()
Migrate phpunit config before running test
@dfsmania
Copy link
Collaborator Author

dfsmania commented Mar 16, 2024

Caution

Again facing problems with uploading coverage to scrutinizer....

Logic that involves downloading ocular.phar do not work:

wget https://scrutinizer-ci.com/ocular.phar
php ocular.phar code-coverage:upload --format=php-clover coverage.clover

This gives the same error we faced before:

[Guzzle\Common\Exception\InvalidArgumentException]  
Invalid handle provided 

Also, we can't use the scrutinizer/ocular dev dependency when testing on Laravel 11. because there's a conflict of package requirements with ocular. So, the only workaround we can use for now, is to keep uploading coverage for Laravel 10.X version, but removing scrutinizer/ocular from the dev dependencies and require it with composer when uploading the coverage.

@dfsmania dfsmania marked this pull request as ready for review March 18, 2024 14:41
@resslinger resslinger merged commit 17d9f1a into master Mar 18, 2024
67 checks passed
@dfsmania dfsmania deleted the add-laravel11-tests-support branch March 18, 2024 14:44
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants