Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Double quotes are escaped incorrectly with backslash in front of them #17

Open
Cheprer opened this issue Nov 30, 2017 · 0 comments
Open

Comments

@Cheprer
Copy link

Cheprer commented Nov 30, 2017

There was problem with parsing a value with a property like this retrieved from calling get on redis-cli normally it would be without " on start and end of the value and key:

\"error\":\"500 - \\\"Failed authorization procedure. domain.com (http-01): urn:acme:error:unknownHost :: The server could not resolve a domain name :: No valid IP addresses found for domain.com\\\\\\\\n\\\\\\\\n\\\"\"

After parsing the message was like this:

"error":"500 - \\"Failed authorization procedure. domain.com (http-01): urn:acme:error:unknownHost :: The server could not resolve a domain name :: No valid IP addresses found for domain.com\\\\n\\\\n\\""

Which is wrong because \" it should be either " or \".

I've made a pull request with changes only thing needed is to code review it and merge it(maybe some versioning). Please let me know once it's on npm.

#16

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

No branches or pull requests

1 participant