-
Notifications
You must be signed in to change notification settings - Fork 124
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
[JENKINS-73824] Add test for deleting a Pipeline job while one of its builds is running only on a OneOffExecutor #468
Conversation
…ng only on a OneOffExecutor
src/test/java/org/jenkinsci/plugins/workflow/job/WorkflowJobTest.java
Outdated
Show resolved
Hide resolved
src/test/java/org/jenkinsci/plugins/workflow/job/WorkflowJobTest.java
Outdated
Show resolved
Hide resolved
The CodeQL autobuild doesn't like the HPI plugin override (interestingly I also get this error in Netbeans, but it works fine using Maven directly):
I suspect that a release of jenkinsci/plugin-pom#1004 would help, but I have not tried to investigate the issue deeply. |
Is there any reason for this to still be in draft? |
@@ -63,7 +63,7 @@ | |||
</pluginRepositories> | |||
<properties> | |||
<changelist>999999-SNAPSHOT</changelist> | |||
<jenkins.version>2.479</jenkins.version> | |||
<jenkins.version>2.480</jenkins.version> |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Given this PR just adds a test, I am not sure if we actually want to merge this as-is, or would prefer to wait for JENKINS-73824 to possibly get backported to 2.479.x.
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Oh OK, it is an lts-candidate
.
Integrated into #470 for simplicity. |
See jenkinsci/jenkins#9790. Once I have an incremental build of that PR I will update this PR to consume it.
Testing done
Submitter checklist