Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

[JENKINS-73824] Add test for deleting a Pipeline job while one of its builds is running only on a OneOffExecutor #468

Closed
wants to merge 6 commits into from

Conversation

dwnusbaum
Copy link
Member

@dwnusbaum dwnusbaum commented Sep 26, 2024

See jenkinsci/jenkins#9790. Once I have an incremental build of that PR I will update this PR to consume it.

Testing done

Submitter checklist

  • Make sure you are opening from a topic/feature/bugfix branch (right side) and not your main branch!
  • Ensure that the pull request title represents the desired changelog entry
  • Please describe what you did
  • Link to relevant issues in GitHub or Jira
  • Link to relevant pull requests, esp. upstream and downstream changes
  • Ensure you have provided tests - that demonstrates feature works or fixes the issue

@dwnusbaum dwnusbaum changed the title Add test for deleting a Pipeline job while one of its builds is running only on a OneOffExecutor [JENKINS-73824] Add test for deleting a Pipeline job while one of its builds is running only on a OneOffExecutor Sep 26, 2024
@jglick jglick added the tests label Sep 26, 2024
@dwnusbaum
Copy link
Member Author

The CodeQL autobuild doesn't like the HPI plugin override (interestingly I also get this error in Netbeans, but it works fine using Maven directly):

[2024-09-27 19:27:07] [autobuild] org.apache.maven.project.ProjectBuildingException: Some problems were encountered while processing the POMs:
Error: 9-27 19:27:07] [autobuild] [ERROR] Unknown packaging: hpi @ org.jenkins-ci.plugins.workflow:workflow-job:${changelist}, /home/runner/work/workflow-job-plugin/workflow-job-plugin/pom.xml, line 37, column 16

I suspect that a release of jenkinsci/plugin-pom#1004 would help, but I have not tried to investigate the issue deeply.

@basil
Copy link
Member

basil commented Sep 27, 2024

pom.xml Outdated Show resolved Hide resolved
pom.xml Outdated Show resolved Hide resolved
pom.xml Outdated Show resolved Hide resolved
@jglick
Copy link
Member

jglick commented Oct 8, 2024

Is there any reason for this to still be in draft?

@@ -63,7 +63,7 @@
</pluginRepositories>
<properties>
<changelist>999999-SNAPSHOT</changelist>
<jenkins.version>2.479</jenkins.version>
<jenkins.version>2.480</jenkins.version>
Copy link
Member Author

@dwnusbaum dwnusbaum Oct 8, 2024

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Given this PR just adds a test, I am not sure if we actually want to merge this as-is, or would prefer to wait for JENKINS-73824 to possibly get backported to 2.479.x.

Copy link
Member

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Oh OK, it is an lts-candidate.

@dwnusbaum
Copy link
Member Author

Integrated into #470 for simplicity.

@dwnusbaum dwnusbaum closed this Oct 15, 2024
@dwnusbaum dwnusbaum deleted the test-deletion branch October 15, 2024 19:02
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants