Diagnostics for FlowDurabilityTest
#960
Merged
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Get occasional flakes in CI in
FlowDurabilityTest.testPauseForcesLowDurabilityToPersist
and some others (CloudBees-internal reference) that I do not understand:After the restart, there are no warnings about the test build, and nothing in the log beyond
and no other threads active. It is as if
RunMap.retrieve
callsreload
(via<init>
) but notonLoad
? No real hypothesis at this point. The test cases in this class generally are clearly prone to flakiness (see the varioussleep
steps andThread.sleep
calls with no guard) but seem potentially important so I am reluctant to just disable them.