From 0ed342260bf73f9d4ff6cbc9406d6f6df9fb1f8e Mon Sep 17 00:00:00 2001 From: arus2023 Date: Thu, 5 Oct 2023 20:37:32 -0500 Subject: [PATCH] Removed 1 unnecessary stubbings in SimpleSVNDirEntryHandlerTest.java --- .../SimpleSVNDirEntryHandlerTest.java | 23 ++++++++++++++++--- 1 file changed, 20 insertions(+), 3 deletions(-) diff --git a/src/test/java/hudson/scm/listtagsparameter/SimpleSVNDirEntryHandlerTest.java b/src/test/java/hudson/scm/listtagsparameter/SimpleSVNDirEntryHandlerTest.java index 78a636f1c..4727aec80 100644 --- a/src/test/java/hudson/scm/listtagsparameter/SimpleSVNDirEntryHandlerTest.java +++ b/src/test/java/hudson/scm/listtagsparameter/SimpleSVNDirEntryHandlerTest.java @@ -41,7 +41,7 @@ public class SimpleSVNDirEntryHandlerTest { @Test public void testSortByName() { SimpleSVNDirEntryHandler handler = new SimpleSVNDirEntryHandler(null); - addEntries(handler); + addEntries2(handler); // TODO: the semantics of using both parameters for handler.getDirs(boolean,boolean) // doesn't seem to have been defined properly @@ -72,7 +72,7 @@ public void testReverseSortByDate() { @Test public void testReverseSortByName() { SimpleSVNDirEntryHandler handler = new SimpleSVNDirEntryHandler(null); - addEntries(handler); + addEntries2(handler); List dirs = handler.getDirs(false, true); Assert.assertEquals(4, dirs.size()); @@ -85,7 +85,7 @@ public void testReverseSortByName() { @Test public void testFilter() { SimpleSVNDirEntryHandler handler = new SimpleSVNDirEntryHandler(".*a.*"); - addEntries(handler); + addEntries2(handler); List dirs = handler.getDirs(); Assert.assertEquals(1, dirs.size()); @@ -109,4 +109,21 @@ private SVNDirEntry getEntry(String lastChanged, String directoryName) throws Pa Mockito.when(entry.getName()).thenReturn(directoryName); return entry; } + + private SVNDirEntry getEntry2(String lastChanged, String directoryName) throws ParseException { + SVNDirEntry entry = Mockito.mock(SVNDirEntry.class); + Mockito.when(entry.getName()).thenReturn(directoryName); + return entry; + } + + private void addEntries2(SimpleSVNDirEntryHandler handler) { + try { + handler.handleDirEntry(getEntry2("2011-11-01", "trunk/a")); + handler.handleDirEntry(getEntry2("2011-11-01", "trunk/b")); + handler.handleDirEntry(getEntry2("2011-10-01", "trunk/x")); + handler.handleDirEntry(getEntry2("2011-09-01", "trunk/c")); + } catch (ParseException | SVNException e) { + Assert.fail(e.toString()); + } + } }