From a0862ac6139d11c05f539ffa8e94cb36c2c6787c Mon Sep 17 00:00:00 2001
From: Josh Soref <jsoref@users.noreply.github.com>
Date: Tue, 7 Jan 2020 16:13:02 -0500
Subject: [PATCH] Add none value

---
 .../scripts/ScriptApproval/index.jelly        | 34 +++++++++++++++----
 1 file changed, 28 insertions(+), 6 deletions(-)

diff --git a/src/main/resources/org/jenkinsci/plugins/scriptsecurity/scripts/ScriptApproval/index.jelly b/src/main/resources/org/jenkinsci/plugins/scriptsecurity/scripts/ScriptApproval/index.jelly
index f5ee57acb..a83c17d36 100644
--- a/src/main/resources/org/jenkinsci/plugins/scriptsecurity/scripts/ScriptApproval/index.jelly
+++ b/src/main/resources/org/jenkinsci/plugins/scriptsecurity/scripts/ScriptApproval/index.jelly
@@ -264,13 +264,35 @@ THE SOFTWARE.
                 </j:otherwise>
             </j:choose>
             <h4 id="approved-signatures">Signatures already approved:</h4>
-            <textarea readonly="readonly" id="approvedSignatures" rows="10" cols="80">
-                <j:forEach var="line" items="${it.approvedSignatures}">${line}<st:out value="&#10;"/></j:forEach>
-            </textarea>
+            <j:choose>
+                <j:when test="${it.approvedSignatures.isEmpty()}">
+                    <p>
+                        None
+                    </p>
+                </j:when>
+                <j:otherwise>
+                    <p>
+                        <textarea readonly="readonly" id="approvedSignatures" rows="10" cols="80">
+                            <j:forEach var="line" items="${it.approvedSignatures}">${line}<st:out value="&#10;"/></j:forEach>
+                        </textarea>
+                    </p>
+                </j:otherwise>
+            </j:choose>
             <h4 id="approved-acl-signatures">Signatures already approved assuming permission check:</h4>
-            <textarea readonly="readonly" id="aclApprovedSignatures" rows="10" cols="80">
-                <j:forEach var="line" items="${it.aclApprovedSignatures}">${line}<st:out value="&#10;"/></j:forEach>
-            </textarea>
+            <j:choose>
+                <j:when test="${it.aclApprovedSignatures.isEmpty()}">
+                    <p>
+                        None
+                    </p>
+                </j:when>
+                <j:otherwise>
+                    <p>
+                        <textarea readonly="readonly" id="aclApprovedSignatures" rows="10" cols="80">
+                            <j:forEach var="line" items="${it.aclApprovedSignatures}">${line}<st:out value="&#10;"/></j:forEach>
+                        </textarea>
+                    </p>
+                </j:otherwise>
+            </j:choose>
             <j:set var="dangerousApprovedSignatures" value="${it.dangerousApprovedSignatures}"/>
             <j:if test="${!empty(dangerousApprovedSignatures)}">
                 <h4 id="dangerous-approved-signatures">Signatures already approved which <strong><font color="red">may have introduced a security vulnerability</font></strong> (recommend clearing):</h4>