Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

VerifyDeployments does not verify rolling updates are completed #119

Open
mnoorl opened this issue Jul 7, 2020 · 5 comments · May be fixed by #321
Open

VerifyDeployments does not verify rolling updates are completed #119

mnoorl opened this issue Jul 7, 2020 · 5 comments · May be fixed by #321

Comments

@mnoorl
Copy link

mnoorl commented Jul 7, 2020

When using a deployment with a rolling update strategy, the verifyDeployments flag will not verify that all replicas have been updated. Instead when it sees that the minimum number of replicas is correct (which can happen multiple times during a rollout before all replicas have been updated) it will mark the deployment as complete.

Perhaps it would be possible to use kubectl rollout status to verify the deployment is complete?
@mnoorl mnoorl changed the title VerifyDeployments does not verify rolling updates are complete VerifyDeployments does not verify rolling updates are completed Jul 7, 2020
@ViliusS
Copy link

ViliusS commented Jul 14, 2022

Hit the same bug today. It's a shame that this plugin doesn't receive more love from Google. 3 years since initial release and we still have to rely on our own hackish Jenkins scripts to manage deployments on GCP :(

@ViliusS
Copy link

ViliusS commented Aug 15, 2022 •
edited
Loading

I have actually looked into this and it looks like it could be very easy to fix. I have two patches almost ready, first uses kubectl rollout status, and the second just adds more checks from kubectl get ... -o json on availableReplicas vs. updatedReplicas vs. replicas, just like it does internally for kubectl rollout status https://github.com/kubernetes/kubectl/blob/24d21a0/pkg/polymorphichelpers/rollout_status.go#L76-L89 .
@craigdbarber which method do you think is more preferable for this plugin?

@ViliusS
Copy link

ViliusS commented Mar 23, 2023 •
edited
Loading

@olamy are you the sole maintainer of this plugin now? If yes, I'm not sure if you can answer my old question above, but we've been running patched version of the plugin for a year now and I can provide a patch to this issue if you are interested.

@olamy
Copy link
Member

olamy commented Mar 25, 2023

@ViliusS I would not qualify myself as a sole maintainer but doing some chore maintenance.
But yes feel free to provide a PR.

@ViliusS ViliusS linked a pull request Apr 9, 2023 that will close this issue
Open
6 tasks
@ViliusS
Copy link

ViliusS commented Apr 9, 2023

Done.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging a pull request may close this issue.

Improve verifications to verify rollout deployments ViliusS/google-kubernetes-engine-plugin
3 participants
@olamy @ViliusS @mnoorl