Skip to content
Permalink

Comparing changes

Choose two branches to see what’s changed or to start a new pull request. If you need to, you can also or learn more about diff comparisons.

Open a pull request

Create a new pull request by comparing changes across two branches. If you need to, you can also . Learn more about diff comparisons here.
base repository: jenkinsci/google-compute-engine-plugin
Failed to load repositories. Confirm that selected base ref is valid, then try again.
Loading
base: 4.573.v7dcd6a_37a_ee2
Choose a base ref
...
head repository: jenkinsci/google-compute-engine-plugin
Failed to load repositories. Confirm that selected head ref is valid, then try again.
Loading
compare: refs/heads/develop
Choose a head ref
  • 16 commits
  • 8 files changed
  • 8 contributors

Commits on May 17, 2024

  1. Do not bundle eddsa library

    the same version comes from the trilead-api plugin that we depend on so
    it would not be used as it does not have the plugin-first classloader.
    
    remove the exclusion from trilead and remove the bundling in this
    plugin
    jtnord committed May 17, 2024
    Configuration menu
    Copy the full SHA
    b606bd3 View commit details
    Browse the repository at this point in the history

Commits on May 30, 2024

  1. Merge pull request #465 from jtnord/do-not-bundle-eddsa

    Do not bundle eddsa library
    jtnord authored May 30, 2024
    Configuration menu
    Copy the full SHA
    6969b7c View commit details
    Browse the repository at this point in the history

Commits on Aug 6, 2024

  1. Configuration menu
    Copy the full SHA
    65a569f View commit details
    Browse the repository at this point in the history
  2. Fixups to #468

    basil committed Aug 6, 2024
    Configuration menu
    Copy the full SHA
    6fe3406 View commit details
    Browse the repository at this point in the history

Commits on Oct 18, 2024

  1. If an exception occurs while launching an agent, the underlying conne…

    …ction and session should be closed
    
    Observed the following stacktrace when running a controller using JDK17
    bytecode level, and having an agent template still configured with a
    JDK11. The agent initially connects fine, however as soon as it attempts
    to do remote classloading, it fails.
    
    As it occurs while setting up the hudson.remoting.Channel itself, the
    listener that is registered during initialization is never called, and
    the exception handling block should instead close the underlying
    resources.
    
    2024-10-18 02:48:21.686+0000 [id=593]	WARNING	c.g.j.p.c.ComputeEngineCloud#log: Error:
    java.lang.UnsupportedClassVersionError: hudson/slaves/SlaveComputer$SlaveVersion has been compiled by a more recent version of the Java Runtime (class file version 61.0), this version of the Java Runtime only recognizes class file versions up to 55.0
    	at java.base/java.lang.ClassLoader.defineClass1(Native Method)
    	at java.base/java.lang.ClassLoader.defineClass(ClassLoader.java:1017)
    	at java.base/java.lang.ClassLoader.defineClass(ClassLoader.java:878)
    	at hudson.remoting.RemoteClassLoader.loadClassFile(RemoteClassLoader.java:470)
    Also:   hudson.remoting.Channel$CallSiteStackTrace: Remote call to gce-cloud-gauntlet3-gaia-jdk11-t4dx04
    		at hudson.remoting.Channel.attachCallSiteStackTrace(Channel.java:1923)
    		at hudson.remoting.UserRequest$ExceptionResponse.retrieve(UserRequest.java:384)
    		at hudson.remoting.Channel.call(Channel.java:1112)
    		at hudson.slaves.SlaveComputer.setChannel(SlaveComputer.java:663)
    		at hudson.slaves.SlaveComputer.setChannel(SlaveComputer.java:441)
    		at PluginClassLoader for google-compute-engine//com.google.jenkins.plugins.computeengine.ComputeEngineComputerLauncher.launch(ComputeEngineComputerLauncher.java:303)
    		at PluginClassLoader for google-compute-engine//com.google.jenkins.plugins.computeengine.ComputeEngineComputerLauncher.launch(ComputeEngineComputerLauncher.java:214)
    		at hudson.slaves.SlaveComputer.lambda$_connect$0(SlaveComputer.java:297)
    		at jenkins.util.ContextResettingExecutorService$2.call(ContextResettingExecutorService.java:46)
    		at jenkins.security.ImpersonatingExecutorService$2.call(ImpersonatingExecutorService.java:80)
    		at java.base/java.util.concurrent.FutureTask.run(FutureTask.java:264)
    		at java.base/java.util.concurrent.ThreadPoolExecutor.runWorker(ThreadPoolExecutor.java:1136)
    		at java.base/java.util.concurrent.ThreadPoolExecutor$Worker.run(ThreadPoolExecutor.java:635)
    		at java.base/java.lang.Thread.run(Thread.java:840)
    Caused: java.lang.UnsupportedClassVersionError: Failed to load hudson.slaves.SlaveComputer$SlaveVersion
    	at hudson.remoting.RemoteClassLoader.loadClassFile(RemoteClassLoader.java:472)
    	at hudson.remoting.RemoteClassLoader.loadRemoteClass(RemoteClassLoader.java:301)
    	at hudson.remoting.RemoteClassLoader.loadWithMultiClassLoader(RemoteClassLoader.java:277)
    	at hudson.remoting.RemoteClassLoader.findClass(RemoteClassLoader.java:236)
    	at java.base/java.lang.ClassLoader.loadClass(ClassLoader.java:589)
    	at java.base/java.lang.ClassLoader.loadClass(ClassLoader.java:522)
    	at java.base/java.lang.Class.forName0(Native Method)
    	at java.base/java.lang.Class.forName(Class.java:398)
    	at hudson.remoting.MultiClassLoaderSerializer$Input.resolveClass(MultiClassLoaderSerializer.java:133)
    	at java.base/java.io.ObjectInputStream.readNonProxyDesc(ObjectInputStream.java:2003)
    	at java.base/java.io.ObjectInputStream.readClassDesc(ObjectInputStream.java:1870)
    	at java.base/java.io.ObjectInputStream.readOrdinaryObject(ObjectInputStream.java:2201)
    	at java.base/java.io.ObjectInputStream.readObject0(ObjectInputStream.java:1687)
    	at java.base/java.io.ObjectInputStream.readObject(ObjectInputStream.java:489)
    	at java.base/java.io.ObjectInputStream.readObject(ObjectInputStream.java:447)
    	at hudson.remoting.UserRequest.deserialize(UserRequest.java:312)
    	at hudson.remoting.UserRequest.perform(UserRequest.java:196)
    	at hudson.remoting.UserRequest.perform(UserRequest.java:50)
    	at hudson.remoting.Request$2.run(Request.java:391)
    	at hudson.remoting.InterceptingExecutorService.lambda$wrap$0(InterceptingExecutorService.java:81)
    	at java.base/java.util.concurrent.FutureTask.run(FutureTask.java:264)
    	at java.base/java.util.concurrent.ThreadPoolExecutor.runWorker(ThreadPoolExecutor.java:1128)
    	at java.base/java.util.concurrent.ThreadPoolExecutor$Worker.run(ThreadPoolExecutor.java:628)
    	at java.base/java.lang.Thread.run(Thread.java:829)
    Caused: java.io.IOException: Remote call on gce-cloud-gauntlet3-gaia-jdk11-t4dx04 failed
    	at hudson.remoting.Channel.call(Channel.java:1116)
    	at hudson.slaves.SlaveComputer.setChannel(SlaveComputer.java:663)
    	at hudson.slaves.SlaveComputer.setChannel(SlaveComputer.java:441)
    	at PluginClassLoader for google-compute-engine//com.google.jenkins.plugins.computeengine.ComputeEngineComputerLauncher.launch(ComputeEngineComputerLauncher.java:303)
    	at PluginClassLoader for google-compute-engine//com.google.jenkins.plugins.computeengine.ComputeEngineComputerLauncher.launch(ComputeEngineComputerLauncher.java:214)
    	at hudson.slaves.SlaveComputer.lambda$_connect$0(SlaveComputer.java:297)
    	at jenkins.util.ContextResettingExecutorService$2.call(ContextResettingExecutorService.java:46)
    	at jenkins.security.ImpersonatingExecutorService$2.call(ImpersonatingExecutorService.java:80)
    	at java.base/java.util.concurrent.FutureTask.run(FutureTask.java:264)
    	at java.base/java.util.concurrent.ThreadPoolExecutor.runWorker(ThreadPoolExecutor.java:1136)
    	at java.base/java.util.concurrent.ThreadPoolExecutor$Worker.run(ThreadPoolExecutor.java:635)
    	at java.base/java.lang.Thread.run(Thread.java:840)
    Vlatombe committed Oct 18, 2024
    Configuration menu
    Copy the full SHA
    ae479e1 View commit details
    Browse the repository at this point in the history
  2. Merge pull request #478 from Vlatombe/close-session-on-exception

    If an exception occurs while launching an agent, the underlying connection and session should be closed
    basil authored Oct 18, 2024
    Configuration menu
    Copy the full SHA
    c9f7ca9 View commit details
    Browse the repository at this point in the history

Commits on Nov 6, 2024

  1. Configuration menu
    Copy the full SHA
    005441d View commit details
    Browse the repository at this point in the history

Commits on Nov 7, 2024

  1. Make sure an instance exists in the cloud before trying to delete it.…

    … Else jenkins nodes cannot be deleted if there is no corresponding instance in the cloud.
    Theoderich committed Nov 7, 2024
    Configuration menu
    Copy the full SHA
    b14ecd1 View commit details
    Browse the repository at this point in the history
  2. Terminate instances immediately if they fail to launch. This gets rid…

    … of zombie offline nodes in jenkins that failed to start in the cloud.
    Theoderich committed Nov 7, 2024
    Configuration menu
    Copy the full SHA
    5ba199e View commit details
    Browse the repository at this point in the history

Commits on Nov 28, 2024

  1. Configuration menu
    Copy the full SHA
    ec6f4b3 View commit details
    Browse the repository at this point in the history

Commits on Dec 9, 2024

  1. Configuration menu
    Copy the full SHA
    627fda8 View commit details
    Browse the repository at this point in the history
  2. Configuration menu
    Copy the full SHA
    f6fc88c View commit details
    Browse the repository at this point in the history

Commits on Dec 11, 2024

  1. Configuration menu
    Copy the full SHA
    ce2791c View commit details
    Browse the repository at this point in the history
  2. Revert "ComputeEnginerInstance terminate instance without checking if…

    … it still exists."
    
    This reverts commit f6fc88c.
    Artmorse committed Dec 11, 2024
    Configuration menu
    Copy the full SHA
    d811f6c View commit details
    Browse the repository at this point in the history

Commits on Dec 12, 2024

  1. Configuration menu
    Copy the full SHA
    181e799 View commit details
    Browse the repository at this point in the history
  2. Merge pull request #489 from Artmorse/issue-381

    Terminate the instance when 404 occured.
    batmat authored Dec 12, 2024
    Configuration menu
    Copy the full SHA
    8aeebbd View commit details
    Browse the repository at this point in the history
Loading