-
Notifications
You must be signed in to change notification settings - Fork 619
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
gitlabCommitStatus does not work with gitlab 16.0.1 #1498
Comments
Any updates? |
Hi @drakenfly The GSoC project is still in progress and will not conclude until later in the summer. So there may not be any updates before then. |
This is a pretty big problem to leave un-fixed pending a complete rework for GSoC. Our entire set of project pipelines is dead in the water until this is fixed. |
My apologies, let me try and get this fixed with a patch this week. |
This might be the root cause: https://docs.gitlab.com/ee/update/deprecations.html?removal_milestone=16.0#legacy-urls-replaced-or-removed The description says "GitLab APIs are not affected by this change" but that may be incorrect. |
Looks like this indeed impacted webhooks: https://gitlab.com/gitlab-org/gitlab/-/merge_requests/57734. This was deprecated a while ago, but they removed the automatic redirects in 16.0. |
Turns out we still need to work out a few testing issues before a new version of GitLab plugin can be released... We are working at it full speed though. |
Six months later. Any progress? |
We've run several tests, but the testing is not complete. Would you like to help with the testing? |
What kind of testing? |
Test the prototype plugin binary in your usual work. Look for places where the new implementation behaves unexpectedly compared to the existing implementation. The automated tests pass, but they are not nearly deep enough to assure that we retain the level of compatibility that users expect. |
Ah, we cannot do that in our current production environment. I would need to stand up a set of completely different servers to do that. Since this bug has been left so long, we've had not choice but to focus our attention on migrating to native GitLab pipelines and we no longer have a set of development/test servers for Jenkins. With this plugin broken for months, we had little choice but to move to something that worked. |
Since we're dead in the water right now and this is dragging for months and months, is there a beta version of this plugin we could use to test? |
We do some branches to be tested by some users. They are:
We are going to continue working on the modernisation over the next few months. So feel free to test these. |
If we work fast enough we can turn these PR's into a beta version to be released for testing next month or so. |
What's the status of this? |
This is still not fixed? |
Yes, I believe this has not yet been fixed, but any contribution towards that effort is welcome |
Jenkins and plugins versions report
Any attempt to update the commit status on Gitlab (version 16.0.1) fails with the error code "Failed to retrieve projectId for project ".
After investigation I found out that it is caused by an api change on the gitlab side. The endpoint "/projects/" no more works properly with project name as value, only project id are accepted instead.
The problem occurs on the version [1.7.14] of gitlab-plugin
What Operating System are you using (both controller, and any agents involved in the problem)?
Ubuntu 22.04
Reproduction steps
Expected Results
The jenkins gitlab plugin is able to pass the build status to the gitlab commit
Actual Results
Gitlab responds with a 404 error code when attempting to fetch the project data by "name with namespace"
Anything else?
No response
The text was updated successfully, but these errors were encountered: