jenkinsutility #4204

Simplify3x · 2024-11-27T12:22:27Z

Repository URL

https://github.com/Simplify3x/simplifyqa-pipeline-executor-plugin

New Repository Name

simplifyqa-pipeline-executor-plugin

Description

when i build the plugins with the parameters,it will execute the testcase and execute the pipelines in simplifyQA.

GitHub users to have commit permission

Jenkins project users to have release permission

Issue tracker

GitHub issues

jenkins-cert-app · 2024-11-27T12:22:34Z

Security audit, information and commands

The security team is auditing all the hosting requests, to ensure a better security by default.

This message informs you that a Jenkins Security Scan was triggered on your repository.
It takes ~10 minutes to complete.

Commands

The bot will parse all comments, and it will check if any line start with a command.

Security team only:

/audit-ok => the audit is complete, the hosting can continue 🎉.
/audit-skip => the audit is not necessary, the hosting can continue 🎉.
/audit-findings => the audit reveals some issues that require corrections ✏️.

Anyone:

/request-security-scan => the findings from the Jenkins Security Scan were corrected, this command will re-scan your repository 🔍.
/audit-review => the findings from the audit were corrected, this command will ping the security team to review the findings 👀. It's only applicable when the previous audit required changes.

Only one command can be requested per comment.

(automatically generated message, version: 1.31.144)

jenkins-cert-app · 2024-11-27T12:22:54Z

❌ Jenkins Security Scan failed.
The Security team was notified about this.

github-actions · 2024-11-27T12:23:14Z

Hello from your friendly Jenkins Hosting Checker

It appears you have some issues with your hosting request. Please see the list below and correct all issues marked Required. Your hosting request will not be approved until these issues are corrected. Issues marked with Warning or Info are just recommendations and will not stall the hosting process.

⛔ Required: The origin repository 'https://github.com/Simplify3x/jenkins-utility.git' ends in .git, please remove this
⛔ Required: The following usernames in 'Jenkins project users to have release permission' need to log into Jira: @Simplify3x (reports are re-synced hourly, wait to re-check for a bit after logging in)
⛔ Required: The following usernames in 'Jenkins project users to have release permission' need to log into Artifactory: @Simplify3x (reports are re-synced hourly, wait to re-check for a bit after logging in)
⛔ Required: Repository URL 'https://github.com/Simplify3x/jenkins-utility' is not a valid GitHub repository (check that you do not have .git at the end, GitHub API doesn't support this).
⚠️ Warning: No pom.xml detected.

You can re-trigger a check by editing your hosting request or by commenting /hosting re-check

Wadeck · 2024-11-27T14:29:15Z

FYI the security scan failed because the repo content is not recognized (it's currently empty)

@Simplify3x please push your branch Dev to master, otherwise it will mess with the tooling I think

github-actions · 2024-11-29T09:51:25Z

Hello from your friendly Jenkins Hosting Checker

It appears you have some issues with your hosting request. Please see the list below and correct all issues marked Required. Your hosting request will not be approved until these issues are corrected. Issues marked with Warning or Info are just recommendations and will not stall the hosting process.

⛔ Required: Please add a license file to your repo, GitHub provides an easy mechanism to do this from their user interface.
⚠️ Warning: No pom.xml detected.

You can re-trigger a check by editing your hosting request or by commenting /hosting re-check

Simplify3x · 2024-11-29T12:21:38Z

done all the changes please host asap

timja · 2024-11-29T12:24:30Z

/hosting re-check

github-actions · 2024-11-29T12:24:57Z

Hello from your friendly Jenkins Hosting Checker

It appears you have some issues with your hosting request. Please see the list below and correct all issues marked Required. Your hosting request will not be approved until these issues are corrected. Issues marked with Warning or Info are just recommendations and will not stall the hosting process.

⛔ Required: Please add a license file to your repo, GitHub provides an easy mechanism to do this from their user interface.
⚠️ Warning: No pom.xml detected.

You can re-trigger a check by editing your hosting request or by commenting /hosting re-check

Simplify3x · 2024-12-02T06:22:15Z

already i have added the license.txt
in the repo

timja · 2024-12-02T09:01:50Z

your repo is empty: https://github.com/Simplify3x/jenkins-utility except for a README

see:

FYI the security scan failed because the repo content is not recognized (it's currently empty)

@Simplify3x please push your branch Dev to master, otherwise it will mess with the tooling I think

Simplify3x · 2024-12-02T09:32:43Z

there is a branch master which has everything

timja · 2024-12-02T09:47:52Z

Well your default branch is main and it has nothing, your plugin needs to be in the default branch

Simplify3x · 2024-12-02T10:19:24Z

kindly review code is now pushed to the main default branch

timja · 2024-12-02T10:35:44Z

/hosting re-check

github-actions · 2024-12-02T10:36:15Z

Hello from your friendly Jenkins Hosting Checker

It appears you have some issues with your hosting request. Please see the list below and correct all issues marked Required. Your hosting request will not be approved until these issues are corrected. Issues marked with Warning or Info are just recommendations and will not stall the hosting process.

⛔ Required: The dependency org.json:json should be replaced with a dependency to the api plugin io.jenkins.plugins:json-api
⛔ Required: The 'artifactId' from the pom.xml (jenkinsutility) should not contain "Jenkins"
⛔ Required: The 'artifactId' from the pom.xml (jenkinsutility) is incorrect, it should be jenkins-utility ('New Repository Name' field with "-plugin" removed)

You can re-trigger a check by editing your hosting request or by commenting /hosting re-check

timja · 2024-12-02T10:38:18Z

Without looking into the code initial feedback:

What does this plugin do? - This should be captured in the README which is full of TODOs
jenkins-utility-plugin is not an appropriate name for a plugin
Please delete the 'junk' at the root of the repo, the files ending with .log and the git file
You should only have one license file, choose one and delete the other

github-actions · 2024-12-02T13:09:43Z

Hello from your friendly Jenkins Hosting Checker

It appears you have some issues with your hosting request. Please see the list below and correct all issues marked Required. Your hosting request will not be approved until these issues are corrected. Issues marked with Warning or Info are just recommendations and will not stall the hosting process.

⛔ Required: The dependency org.json:json should be replaced with a dependency to the api plugin io.jenkins.plugins:json-api
⛔ Required: The 'artifactId' from the pom.xml (jenkinsutility) should not contain "Jenkins"
⛔ Required: The 'artifactId' from the pom.xml (jenkinsutility) is incorrect, it should be simplifyqa-pipeline-executor-plugin ('New Repository Name' field with "-plugin" removed)

You can re-trigger a check by editing your hosting request or by commenting /hosting re-check

Simplify3x · 2024-12-02T13:09:51Z

have updated the above requirements

Simplify3x · 2024-12-03T12:19:18Z

kindly update me the required time for hosting

timja · 2024-12-03T12:34:07Z

kindly update me the required time for hosting

Please put forward a better case for hosting, review your documentation and code, we need to be able to understand what your plugin is and why its beneficial that it should be hosted.

Title in README doesn't map to your plugin name
Please review your markdown rendering is broken is almost every section
Do not recommend installing from source, instructions should default to downloading from Manage plugins
Review your code ensuring you use your own java package and not sample
You're missing support for proxies in https://github.com/Simplify3x/SimplifyQA-Pipeline-Executor-Plugin/blob/main/src/main/java/io/jenkins/plugins/sample/service/ExecutionService.java#L36, please take a look at ProxyConfiguration in Jenkins core
Removed commented out code https://github.com/Simplify3x/SimplifyQA-Pipeline-Executor-Plugin/blob/main/src/main/java/io/jenkins/plugins/sample/model/Execution.java, https://github.com/Simplify3x/SimplifyQA-Pipeline-Executor-Plugin/blob/main/src/main/java/io/jenkins/plugins/sample/model/Metadata.java
Nothing seems to call this? https://github.com/Simplify3x/SimplifyQA-Pipeline-Executor-Plugin/blob/89f68a46dc9e4deb158b2228b5b377327a687297/src/main/java/io/jenkins/plugins/sample/service/ExecutionService.java#L18

mawinter69 · 2024-12-04T12:02:38Z

welcome is not suitable name for a pipeline step: https://github.com/Simplify3x/SimplifyQA-Pipeline-Executor-Plugin/blame/a13cc7891ba0f0fd7e37a021e5e7e3d9f2d74de3/src/main/java/com/simplifyqa/SimplifyQAPipelineExecutor.java#L119
remove the version for json, it is defined in the bom https://github.com/Simplify3x/SimplifyQA-Pipeline-Executor-Plugin/blob/a13cc7891ba0f0fd7e37a021e5e7e3d9f2d74de3/pom.xml#L66
use the jackson api plugin without a version https://github.com/Simplify3x/SimplifyQA-Pipeline-Executor-Plugin/blob/a13cc7891ba0f0fd7e37a021e5e7e3d9f2d74de3/pom.xml#L57
the field useFrench is not used and should be removed ( is that a leftover from the sample?) https://github.com/Simplify3x/SimplifyQA-Pipeline-Executor-Plugin/blob/a13cc7891ba0f0fd7e37a021e5e7e3d9f2d74de3/src/main/java/com/simplifyqa/SimplifyQAPipelineExecutor.java#L25

Repeating my question:
Why a new plugin when you already have https://plugins.jenkins.io/simplify-qa-connector/
Instead of creating new plugins you could make the existing plugin work with both versions (e.g. with an additional attribute for the version) or just add the new step there. You could then also print something in the logs when the old step is used that it is deprecated and the new step should be used.

Simplify3x · 2024-12-04T19:09:49Z

Regarding the Jackson version removal: If the Jackson version is removed from the pom.xml, the plugin might not be able to resolve and load the correct version of Jackson, causing issues where it doesn’t function as expected. We have updated everything else, but maintaining the version explicitly ensures the plugin works correctly and avoids potential version conflicts.

As for the question about the Simplify QA Connector plugin: At the architectural level, there are significant changes between the two projects, and they can be considered as two distinct products. The older version of the plugin may be deprecated and sunset by mid of next year, so it was necessary to create a new plugin to better align with the updated architecture and new features

mawinter69 · 2024-12-04T19:36:45Z

Currently you define a dedicated dependency to jackson (not to the plugin) and this will lead to the corresponding jar file getting packed in the hpi file of the plugin. As you can assume that the jackson plugin is also installed (it is used by a lot of plugins) this can lead to unexpected problems as there are then 2 version of the jackson jar file in the classpath. Afaik your plugin will get the classes from the jackson plugin normally and not what is packed in your own plugin. But there might be situation where this is not the case and then you will get errors that are hard to understand for your users.
So defining the dependency to the jackson api plugin is your best option to avoid problems. The jackson library is pretty stable and wouldn't expect any problems with it.

<dependency>
    <groupId>org.jenkins-ci.plugins</groupId>
    <artifactId>jackson2-api</artifactId>
</dependency>

I don't think anyone will approve your plugin with an explicit dependency to the plain jackson library.

Simplify3x · 2024-12-05T08:17:41Z

updated with dependency

alecharp · 2024-12-05T14:10:55Z

@Simplify3x I'm still not understanding the difference from https://plugins.jenkins.io/simplify-qa-connector/. If you have a new feature, why not adding it to that plugin instead? A new plugin, means more maintenance, transitioning users to the new process is more complex, etc.

You can have the existing plugin offering the new feature for less cost.

Simplify3x · 2024-12-05T17:32:23Z

Hello, I am reaching out to understand the timeline and further procedures required to host SimplifyQA-Pipeline-Executor-Plugin on Jenkins. Could you please provide an estimated time frame for setting up the hosting?

Additionally, I would appreciate any details or documentation outlining the steps or requirements needed from our side to facilitate this process.

timja · 2024-12-16T11:37:16Z

/hosting re-check

github-actions · 2024-12-16T11:37:51Z

Hello from your friendly Jenkins Hosting Checker

It appears you have some issues with your hosting request. Please see the list below and correct all issues marked Required. Your hosting request will not be approved until these issues are corrected. Issues marked with Warning or Info are just recommendations and will not stall the hosting process.

⛔ Required: Repository 'https://github.com/Simplify3x/simplifyqa-pipeline-executor-plugin' already has the following forks in the jenkinsci org: jenkinsci/simplifyqa-pipeline-executor-plugin

You can re-trigger a check by editing your hosting request or by commenting /hosting re-check

Simplify3x · 2024-12-18T08:14:36Z

@timja i haven done this fork could tell me what is should now

Simplify3x · 2024-12-18T08:14:52Z

/hosting re-check

github-actions · 2024-12-18T08:15:30Z

Hello from your friendly Jenkins Hosting Checker

It appears you have some issues with your hosting request. Please see the list below and correct all issues marked Required. Your hosting request will not be approved until these issues are corrected. Issues marked with Warning or Info are just recommendations and will not stall the hosting process.

⛔ Required: Repository 'https://github.com/Simplify3x/simplifyqa-pipeline-executor-plugin' already has the following forks in the jenkinsci org: jenkinsci/simplifyqa-pipeline-executor-plugin

You can re-trigger a check by editing your hosting request or by commenting /hosting re-check

Simplify3x · 2024-12-18T08:27:25Z

/hosting re-check

github-actions · 2024-12-18T08:27:54Z

Hello from your friendly Jenkins Hosting Checker

It appears you have some issues with your hosting request. Please see the list below and correct all issues marked Required. Your hosting request will not be approved until these issues are corrected. Issues marked with Warning or Info are just recommendations and will not stall the hosting process.

⛔ Required: Repository 'https://github.com/Simplify3x/simplifyqa-pipeline-executor-plugin' already has the following forks in the jenkinsci org: jenkinsci/old-simplifyqa-pipeline-executor-plugin

You can re-trigger a check by editing your hosting request or by commenting /hosting re-check

Simplify3x · 2024-12-18T08:28:50Z

@timja requesting to detach the fork in the jenkinsci org: jenkinsci/simplifyqa-pipeline-executor-plugin as we havent done this.

Simplify3x · 2024-12-18T08:30:52Z

/hosting re-check

github-actions · 2024-12-18T08:31:30Z

Hello from your friendly Jenkins Hosting Checker

It appears you have some issues with your hosting request. Please see the list below and correct all issues marked Required. Your hosting request will not be approved until these issues are corrected. Issues marked with Warning or Info are just recommendations and will not stall the hosting process.

⛔ Required: Repository 'https://github.com/Simplify3x/simplifyqa-pipeline-executor-plugin' already has the following forks in the jenkinsci org: jenkinsci/old-simplifyqa-pipeline-executor-plugin

You can re-trigger a check by editing your hosting request or by commenting /hosting re-check

Simplify3x · 2024-12-18T08:51:54Z

/hosting re-check

github-actions · 2024-12-18T08:52:25Z

Hello from your friendly Jenkins Hosting Checker

It appears you have some issues with your hosting request. Please see the list below and correct all issues marked Required. Your hosting request will not be approved until these issues are corrected. Issues marked with Warning or Info are just recommendations and will not stall the hosting process.

⛔ Required: Repository 'https://github.com/Simplify3x/simplifyqa-pipeline-executor-plugin' already has the following forks in the jenkinsci org: jenkinsci/old-simplifyqa-pipeline-executor-plugin

You can re-trigger a check by editing your hosting request or by commenting /hosting re-check

github-actions · 2024-12-18T08:55:41Z

Hello from your friendly Jenkins Hosting Checker

It appears you have some issues with your hosting request. Please see the list below and correct all issues marked Required. Your hosting request will not be approved until these issues are corrected. Issues marked with Warning or Info are just recommendations and will not stall the hosting process.

⛔ Required: Repository 'https://github.com/Simplify3x/simplifyqa-automation-hub-plugin' already has the following forks in the jenkinsci org: jenkinsci/old-simplifyqa-pipeline-executor-plugin

You can re-trigger a check by editing your hosting request or by commenting /hosting re-check

timja · 2024-12-18T08:55:45Z

you don't need to hosting re-check, hosting is complete

Simplify3x · 2024-12-18T08:55:46Z

/hosting re-check

github-actions · 2024-12-18T08:56:03Z

Hello from your friendly Jenkins Hosting Checker

It appears you have some issues with your hosting request. Please see the list below and correct all issues marked Required. Your hosting request will not be approved until these issues are corrected. Issues marked with Warning or Info are just recommendations and will not stall the hosting process.

⛔ Required: Repository 'https://github.com/Simplify3x/simplifyqa-automation-hub-plugin' already has the following forks in the jenkinsci org: jenkinsci/old-simplifyqa-pipeline-executor-plugin

You can re-trigger a check by editing your hosting request or by commenting /hosting re-check

github-actions · 2024-12-18T08:56:29Z

Hello from your friendly Jenkins Hosting Checker

It appears you have some issues with your hosting request. Please see the list below and correct all issues marked Required. Your hosting request will not be approved until these issues are corrected. Issues marked with Warning or Info are just recommendations and will not stall the hosting process.

⛔ Required: Repository 'https://github.com/Simplify3x/simplifyqa-automation-hub-plugin' already has the following forks in the jenkinsci org: jenkinsci/old-simplifyqa-pipeline-executor-plugin

You can re-trigger a check by editing your hosting request or by commenting /hosting re-check

Simplify3x · 2024-12-18T08:56:35Z

@timja i havent done this jenkinsci/old-simplifyqa-pipeline-executor-plugin

github-actions · 2024-12-18T08:59:45Z

Hello from your friendly Jenkins Hosting Checker

It appears you have some issues with your hosting request. Please see the list below and correct all issues marked Required. Your hosting request will not be approved until these issues are corrected. Issues marked with Warning or Info are just recommendations and will not stall the hosting process.

⛔ Required: Repository 'https://github.com/Simplify3x/simplifyqa-pipeline-executor-plugin' already has the following forks in the jenkinsci org: jenkinsci/old-simplifyqa-pipeline-executor-plugin

You can re-trigger a check by editing your hosting request or by commenting /hosting re-check

timja · 2024-12-18T09:01:04Z

@timja i havent done this jenkinsci/old-simplifyqa-pipeline-executor-plugin

Is it supposed to be called old-..?

Simplify3x · 2024-12-18T09:01:19Z

no

timja · 2024-12-18T09:02:18Z

I've renamed it back, you should be good to go

Simplify3x · 2024-12-18T09:02:31Z

its was giving this error that the reason i have change it to old :

Required: Repository 'https://github.com/Simplify3x/simplifyqa-pipeline-executor-plugin' already has the following forks in the jenkinsci org: jenkinsci/old-simplifyqa-pipeline-executor-plugin

Simplify3x · 2024-12-18T09:03:42Z

ok
but when i can see the plugin in https://plugins.jenkins.io/ ?

Simplify3x · 2024-12-18T09:05:22Z

and can i get access of jenkinsci/old-simplifyqa-pipeline-executor-plugin

timja · 2024-12-18T09:12:55Z

@Simplify3x to see it on the marketplace you need to release it: https://www.jenkins.io/doc/developer/publishing/releasing/

You had access as I can see you updated the pom.xml file about 40 minutes ago but it looks like you removed yourself?

I've re-added your permission to https://github.com/jenkinsci/simplifyqa-pipeline-executor-plugin

Simplify3x added the hosting-request Request to host a component in jenkinsci label Nov 27, 2024

jenkins-cert-app added the security-audit-todo The security team needs to audit the hosting request code label Nov 27, 2024

github-actions bot added the needs-fix label Nov 27, 2024

timja mentioned this issue Dec 4, 2024

QA Pipeline Automation Plugin for Jenkins #4210

Closed

github-actions bot added needs-fix and removed bot-check-complete Automated hosting checks passed labels Dec 16, 2024

timja mentioned this issue Dec 16, 2024

Hosting checker didn't fail when no GitHub user or Jenkins project users #4231

Closed

mawinter69 mentioned this issue Dec 20, 2024

check that user lists contain at least 1 user #4233

Merged

jenkinsutility #4204

jenkinsutility #4204

Comments

Simplify3x commented Nov 27, 2024 • edited Loading

Repository URL

New Repository Name

Description

GitHub users to have commit permission

Jenkins project users to have release permission

Issue tracker

jenkins-cert-app commented Nov 27, 2024

jenkins-cert-app commented Nov 27, 2024

github-actions bot commented Nov 27, 2024

Wadeck commented Nov 27, 2024

github-actions bot commented Nov 29, 2024

Simplify3x commented Nov 29, 2024

timja commented Nov 29, 2024

github-actions bot commented Nov 29, 2024

Simplify3x commented Dec 2, 2024

timja commented Dec 2, 2024

Simplify3x commented Dec 2, 2024

timja commented Dec 2, 2024

Simplify3x commented Dec 2, 2024

timja commented Dec 2, 2024

github-actions bot commented Dec 2, 2024

timja commented Dec 2, 2024

github-actions bot commented Dec 2, 2024

Simplify3x commented Dec 2, 2024

Simplify3x commented Dec 3, 2024

timja commented Dec 3, 2024

mawinter69 commented Dec 4, 2024

Simplify3x commented Dec 4, 2024

mawinter69 commented Dec 4, 2024

Simplify3x commented Dec 5, 2024

alecharp commented Dec 5, 2024

Simplify3x commented Dec 5, 2024

timja commented Dec 16, 2024

github-actions bot commented Dec 16, 2024

Simplify3x commented Dec 18, 2024

Simplify3x commented Dec 18, 2024

github-actions bot commented Dec 18, 2024

Simplify3x commented Dec 18, 2024

github-actions bot commented Dec 18, 2024

Simplify3x commented Dec 18, 2024

Simplify3x commented Dec 18, 2024

github-actions bot commented Dec 18, 2024

Simplify3x commented Dec 18, 2024

github-actions bot commented Dec 18, 2024

github-actions bot commented Dec 18, 2024

timja commented Dec 18, 2024

Simplify3x commented Dec 18, 2024

github-actions bot commented Dec 18, 2024

github-actions bot commented Dec 18, 2024

Simplify3x commented Dec 18, 2024

github-actions bot commented Dec 18, 2024

timja commented Dec 18, 2024

Simplify3x commented Dec 18, 2024

timja commented Dec 18, 2024

Simplify3x commented Dec 18, 2024

Simplify3x commented Dec 18, 2024

Simplify3x commented Dec 18, 2024

timja commented Dec 18, 2024

Simplify3x commented Nov 27, 2024 •

edited

Loading