Hosting request for testwheel-api

[aprasanth3192]

Repository URL

https://github.com/Yakshna-Corporation/testwheel-trigger

New Repository Name

testwheel-trigger-plugin

Description

TestWheel- Jenkins Plugin. You use this plugin to trigger test automation through Jenkins CI.

GitHub users to have commit permission

@baskerganesan
@prakashp1987
@aprasanth3192

Jenkins project users to have release permission

baskerGanesan
prakashp1987
prasantha

Issue tracker

GitHub issues

[jenkins-cert-app]

Security audit, information and commands

The security team is auditing all the hosting requests, to ensure a better security by default.

This message informs you that a Jenkins Security Scan was triggered on your repository.
It takes ~10 minutes to complete.

Commands

The bot will parse all comments, and it will check if any line start with a command.

Security team only:

• /audit-ok => the audit is complete, the hosting can continue 🎉.
• /audit-skip => the audit is not necessary, the hosting can continue 🎉.
• /audit-findings => the audit reveals some issues that require corrections ✏️.

Anyone:

• /request-security-scan => the findings from the Jenkins Security Scan were corrected, this command will re-scan your repository 🔍.
• /audit-review => the findings from the audit were corrected, this command will ping the security team to review the findings 👀. It's only applicable when the previous audit required changes.

Only one command can be requested per comment.

(automatically generated message, version: 1.29.18)

[github-actions]

Hello from your friendly Jenkins Hosting Checker

It appears you have some issues with your hosting request. Please see the list below and correct all issues marked Required. Your hosting request will not be approved until these issues are corrected. Issues marked with Warning or Info are just recommendations and will not stall the hosting process.

• ⛔ Required: You must specify an <scm> block in your pom.xml. See https://maven.apache.org/pom.html#SCM for more information.
• ⛔ Required: The following usernames in 'Jenkins project users to have release permission' need to log into Jira: baskerGanesan, prakashkp88 (reports are re-synced hourly, wait to re-check for a bit after logging in)
• ⛔ Required: The following usernames in 'Jenkins project users to have release permission' need to log into Artifactory: baskerGanesan, prakashkp88, prasantha (reports are re-synced hourly, wait to re-check for a bit after logging in)
• ⛔ Required: The dependency org.json:json should be replaced with a dependency to the api plugin io.jenkins.plugins:json-api
• ⛔ Required: The dependency org.apache.httpcomponents.client5:httpclient5 should be replaced with a dependency to the api plugin io.jenkins.plugins:apache-httpcomponents-client-5-api
• ⛔ Required: The 'artifactId' from the pom.xml (api-plugin) is incorrect, it should be my-api ('New Repository Name' field with "-plugin" removed)
• ⛔ Required: Please specify a license in your pom.xml file using the <licenses> tag. See https://maven.apache.org/pom.html#Licenses for more information.

You can re-trigger a check by editing your hosting request or by commenting /hosting re-check

[jenkins-cert-app]

The Jenkins Security Scan did not find anything dangerous with your plugin, congratulations! 🎉

---

💡 The Security team recommends that you are setting up the scan in your repository by following our guide.

[mawinter69]

• Please give you plugin a meaningful name instead of my-api or just api e.g. testwheel-trigger
  So the repo name should be testwheel-trigger-plugin and the artifactid should then be testwheel-trigger
• https://github.com/Yakshna-Corporation/testwheel-trigger/blob/a36232abb70c80ed7f1de25f71b8d1eaca48e408/src/main/java/org/yakshna/testwheel/apiplugin/APICallBuilder.java#L126, use e.g. testwheelTrigger for the Symbol, this is what you will use in a pipeline job and apiCallBuilder doesn't give any hint what the step is doing
• https://github.com/Yakshna-Corporation/testwheel-trigger/blob/a36232abb70c80ed7f1de25f71b8d1eaca48e408/src/main/java/org/yakshna/testwheel/apiplugin/APICallBuilder.java#L131 use TestWheel Trigger in the displayname so people know in the build step dropdown in a freestyle job what the step is doing
• https://github.com/Yakshna-Corporation/testwheel-trigger/blob/a36232abb70c80ed7f1de25f71b8d1eaca48e408/src/main/java/org/yakshna/testwheel/apiplugin/APICallBuilder.java#L74 this code will not work when the job runs on an agent. You will need to use https://javadoc.jenkins.io/hudson/FilePath.html -> write()
• https://github.com/Yakshna-Corporation/testwheel-trigger/blob/a36232abb70c80ed7f1de25f71b8d1eaca48e408/src/main/resources/index.jelly#L3 please fill in a meaningful description here what the plugin is doing. This is shown in the plugin manager to users
• https://github.com/Yakshna-Corporation/testwheel-trigger/blob/a36232abb70c80ed7f1de25f71b8d1eaca48e408/pom.xml#L15 use a better name that includes TestWheel
• remove https://github.com/Yakshna-Corporation/testwheel-trigger/blob/a36232abb70c80ed7f1de25f71b8d1eaca48e408/pom.xml#L19-L24, the plugin should be built with jdk11 for now
• https://github.com/Yakshna-Corporation/testwheel-trigger/blob/a36232abb70c80ed7f1de25f71b8d1eaca48e408/pom.xml#L18 stick to the jenkins version that you have specified in the bom at line 30
• https://github.com/Yakshna-Corporation/testwheel-trigger/blob/a36232abb70c80ed7f1de25f71b8d1eaca48e408/pom.xml#L38 the dependency is not required you get it implicitly
• https://github.com/Yakshna-Corporation/testwheel-trigger/blob/a36232abb70c80ed7f1de25f71b8d1eaca48e408/pom.xml#L44 the dependency to structs is not required
• https://github.com/Yakshna-Corporation/testwheel-trigger/blob/a36232abb70c80ed7f1de25f71b8d1eaca48e408/pom.xml#L73 the dependency to common-io is not required
• The code is limited to freestyle jobs because of https://github.com/Yakshna-Corporation/testwheel-trigger/blob/a36232abb70c80ed7f1de25f71b8d1eaca48e408/src/main/java/org/yakshna/testwheel/apiplugin/APICallBuilder.java#L131, there is no reason for this limitation

[aprasanth3192]

/hosting re-check

[aprasanth3192]

@jenkinsci/jenkins-maintainers

Hello, I've made the required changes as per the feedback. Could you please review the updates and let me know if any further changes are needed? Thank you!

[timja]

/hosting re-check

[github-actions]

Hello from your friendly Jenkins Hosting Checker

It appears you have some issues with your hosting request. Please see the list below and correct all issues marked Required. Your hosting request will not be approved until these issues are corrected. Issues marked with Warning or Info are just recommendations and will not stall the hosting process.

• ⛔ Required: The following usernames in 'Jenkins project users to have release permission' need to log into Jira: baskerGanesan, prakashkp88 (reports are re-synced hourly, wait to re-check for a bit after logging in)
• ⛔ Required: The following usernames in 'Jenkins project users to have release permission' need to log into Artifactory: baskerGanesan, prakashkp88 (reports are re-synced hourly, wait to re-check for a bit after logging in)
• ⛔ Required: The 'artifactId' from the pom.xml (testwheel-trigger) is incorrect, it should be my-api ('New Repository Name' field with "-plugin" removed)
• ⛔ Required: Please specify a license in your pom.xml file using the <licenses> tag. See https://maven.apache.org/pom.html#Licenses for more information.

You can re-trigger a check by editing your hosting request or by commenting /hosting re-check

[timja]

Hi please review the title and the description you haven't addressed the first feedback from #4116 (comment)

[github-actions]

Hello from your friendly Jenkins Hosting Checker

It appears you have some issues with your hosting request. Please see the list below and correct all issues marked Required. Your hosting request will not be approved until these issues are corrected. Issues marked with Warning or Info are just recommendations and will not stall the hosting process.

• ⛔ Required: The following usernames in 'Jenkins project users to have release permission' need to log into Jira: baskerGanesan, prakashkp88 (reports are re-synced hourly, wait to re-check for a bit after logging in)
• ⛔ Required: The following usernames in 'Jenkins project users to have release permission' need to log into Artifactory: baskerGanesan, prakashkp88 (reports are re-synced hourly, wait to re-check for a bit after logging in)
• ⛔ Required: The 'artifactId' from the pom.xml (testwheel-api-plugin) is incorrect, it should be my-api ('New Repository Name' field with "-plugin" removed)
• ⛔ Required: Please specify a license in your pom.xml file using the <licenses> tag. See https://maven.apache.org/pom.html#Licenses for more information.

You can re-trigger a check by editing your hosting request or by commenting /hosting re-check

[aprasanth3192]

@jenkinsci/jenkins-maintainers

1. I want to change my repository name to testwheel-api-plugin as mentioned in my POM.
2. We have updated username across jira, github and artifactory as prakashp1987 with all necessary permissions.

[aprasanth3192]

@jenkinsci/jenkins-maintainers
/hosting re-check

Hi. I have made a change as per requirement feedback. could you please review the updates and let me know if any further changes are needed. Thank you

[timja]

/hosting re-check

[github-actions]

Hello from your friendly Jenkins Hosting Checker

It appears you have some issues with your hosting request. Please see the list below and correct all issues marked Required. Your hosting request will not be approved until these issues are corrected. Issues marked with Warning or Info are just recommendations and will not stall the hosting process.

• ⛔ Required: The following usernames in 'Jenkins project users to have release permission' need to log into Jira: baskerGanesan, prakashkp88 (reports are re-synced hourly, wait to re-check for a bit after logging in)
• ⛔ Required: The following usernames in 'Jenkins project users to have release permission' need to log into Artifactory: baskerGanesan, prakashkp88 (reports are re-synced hourly, wait to re-check for a bit after logging in)
• ⛔ Required: The following usernames in 'GitHub Users to Authorize as Committers' are not valid GitHub usernames or are Organizations: prakashkp88
• ⛔ Required: The 'artifactId' from the pom.xml (testwheel-api-plugin) is incorrect, it should be my-api ('New Repository Name' field with "-plugin" removed)

You can re-trigger a check by editing your hosting request or by commenting /hosting re-check

[github-actions]

Hello from your friendly Jenkins Hosting Checker

It appears you have some issues with your hosting request. Please see the list below and correct all issues marked Required. Your hosting request will not be approved until these issues are corrected. Issues marked with Warning or Info are just recommendations and will not stall the hosting process.

• ⛔ Required: The following usernames in 'Jenkins project users to have release permission' need to log into Jira: baskerGanesan, prakashkp88 (reports are re-synced hourly, wait to re-check for a bit after logging in)
• ⛔ Required: The following usernames in 'Jenkins project users to have release permission' need to log into Artifactory: baskerGanesan, prakashkp88 (reports are re-synced hourly, wait to re-check for a bit after logging in)
• ⛔ Required: The following usernames in 'GitHub Users to Authorize as Committers' are not valid GitHub usernames or are Organizations: prakashkp88
• ⛔ Required: The 'artifactId' from the pom.xml (testwheel-api-plugin) is incorrect, it should be testwheel-api ('New Repository Name' field with "-plugin" removed)

You can re-trigger a check by editing your hosting request or by commenting /hosting re-check

[github-actions]

Hello from your friendly Jenkins Hosting Checker

It appears you have some issues with your hosting request. Please see the list below and correct all issues marked Required. Your hosting request will not be approved until these issues are corrected. Issues marked with Warning or Info are just recommendations and will not stall the hosting process.

• ⛔ Required: The following usernames in 'Jenkins project users to have release permission' need to log into Jira: baskerGanesan, prakashkp88 (reports are re-synced hourly, wait to re-check for a bit after logging in)
• ⛔ Required: The following usernames in 'Jenkins project users to have release permission' need to log into Artifactory: baskerGanesan, prakashkp88 (reports are re-synced hourly, wait to re-check for a bit after logging in)
• ⛔ Required: The following usernames in 'GitHub Users to Authorize as Committers' are not valid GitHub usernames or are Organizations: prakashkp88
• ⛔ Required: The 'artifactId' from the pom.xml (testwheel-api-plugin) is incorrect, it should be testwheel-api ('New Repository Name' field with "-plugin" removed)

You can re-trigger a check by editing your hosting request or by commenting /hosting re-check

[github-actions]

Hello from your friendly Jenkins Hosting Checker

It appears you have some issues with your hosting request. Please see the list below and correct all issues marked Required. Your hosting request will not be approved until these issues are corrected. Issues marked with Warning or Info are just recommendations and will not stall the hosting process.

• ⛔ Required: The following usernames in 'Jenkins project users to have release permission' need to log into Jira: baskerGanesan, prakashkp88 (reports are re-synced hourly, wait to re-check for a bit after logging in)
• ⛔ Required: The following usernames in 'Jenkins project users to have release permission' need to log into Artifactory: baskerGanesan, prakashkp88 (reports are re-synced hourly, wait to re-check for a bit after logging in)
• ⛔ Required: The following usernames in 'GitHub Users to Authorize as Committers' are not valid GitHub usernames or are Organizations: prakashkp88
• ⛔ Required: The 'artifactId' from the pom.xml (testwheel-api-plugin) is incorrect, it should be testwheel-api ('New Repository Name' field with "-plugin" removed)
• ⛔ Required: 'New Repository Name' must end with "-plugin" (disregard if you are not requesting hosting of a plugin)

You can re-trigger a check by editing your hosting request or by commenting /hosting re-check

[github-actions]

Hello from your friendly Jenkins Hosting Checker

It appears you have some issues with your hosting request. Please see the list below and correct all issues marked Required. Your hosting request will not be approved until these issues are corrected. Issues marked with Warning or Info are just recommendations and will not stall the hosting process.

• ⛔ Required: The following usernames in 'Jenkins project users to have release permission' need to log into Jira: baskerGanesan (reports are re-synced hourly, wait to re-check for a bit after logging in)
• ⛔ Required: The following usernames in 'Jenkins project users to have release permission' need to log into Artifactory: baskerGanesan (reports are re-synced hourly, wait to re-check for a bit after logging in)
• ⛔ Required: The 'artifactId' from the pom.xml (testwheel-api-plugin) is incorrect, it should be testwheel-api ('New Repository Name' field with "-plugin" removed)
• ⛔ Required: 'New Repository Name' must end with "-plugin" (disregard if you are not requesting hosting of a plugin)

You can re-trigger a check by editing your hosting request or by commenting /hosting re-check

[github-actions]

Hello from your friendly Jenkins Hosting Checker

It appears you have some issues with your hosting request. Please see the list below and correct all issues marked Required. Your hosting request will not be approved until these issues are corrected. Issues marked with Warning or Info are just recommendations and will not stall the hosting process.

• ⛔ Required: The following usernames in 'Jenkins project users to have release permission' need to log into Jira: baskerGanesan (reports are re-synced hourly, wait to re-check for a bit after logging in)
• ⛔ Required: The following usernames in 'Jenkins project users to have release permission' need to log into Artifactory: baskerGanesan (reports are re-synced hourly, wait to re-check for a bit after logging in)

You can re-trigger a check by editing your hosting request or by commenting /hosting re-check

[baskerganesan]

Logged in using baskerGanesan

[timja]

/hosting re-check

[github-actions]

Hello from your friendly Jenkins Hosting Checker

It appears you have some issues with your hosting request. Please see the list below and correct all issues marked Required. Your hosting request will not be approved until these issues are corrected. Issues marked with Warning or Info are just recommendations and will not stall the hosting process.

• ⛔ Required: The following usernames in 'Jenkins project users to have release permission' need to log into Jira: baskerGanesan (reports are re-synced hourly, wait to re-check for a bit after logging in)

You can re-trigger a check by editing your hosting request or by commenting /hosting re-check

[baskerganesan]

/hosting re-check

[prakashp1987]

@mawinter69 I have updated the content in index.jelly file based on the code changes. Could you be specific on what was worng in jelly file. I will work on ProxyConfiguration in the mean time

[mawinter69]

• the file https://github.com/Yakshna-Corporation/testwheel-trigger/blob/main/src/main/resources/org/yakshna/testwheel/apiplugin/APICallBuilder/config.jelly is in the wrong location. It must be in in the folder src/main/resources/org/yakshna/testwheel/apiplugin/TestWheelTrigger/
• The content of the that config.jelly doesn't fit to what fields are defined in TestWheelTrigger.java

[prakashp1987]

@mawinter69 Updated config.jelly & ProxyConfiguration Class.

/hosting re-check

[mawinter69]

/request-security-scan

[jenkins-cert-app]

The Jenkins Security Scan discovered 1 finding(s) 🔍.

For every identified issue, please do one of the following:

• Implement the recommended fix to address the issue.
• If you think it's a false positive, suppress the warning directly within the code.
• Alternative, you write an explanation here about why you think it's irrelevant. That will require a manual review, leading to a slower process.

After addressing the findings through one of the above methods:

• If all modifications have been made to the code, please initiate a new security scan by triggering the /request-security-scan command.
• If there are any unresolved findings (those not corrected or suppressed), request a review from the Jenkins security team by using the /audit-review command.

---

Jenkins: Plaintext password storage

You can find detailed information about this finding here.

TestWheelTrigger.java#43

Field should be reviewed whether it stores a password and is serialized to disk: prjctKey

[mawinter69]

There is a problem that your repo is not indexed in github. Due to this the hosting checker is not working properly and fails to identify certain problems.

• https://github.com/Yakshna-Corporation/testwheel-trigger/blob/3adaad9fbaf77a3f645fa0f494f028b608a4f717/src/main/resources/index.jelly#L1 This is a jelly file so it must have
  <?jelly escape-by-default='true'?> at the beginning

Such things should be found when you run mvn test btw

[prakashp1987]

@mawinter69
/request-security-scan
/hosting re-check

[jenkins-cert-app]

The Jenkins Security Scan did not find anything dangerous with your plugin, congratulations! 🎉

---

💡 The Security team recommends that you are setting up the scan in your repository by following our guide.

[prakashp1987]

@mawinter69
/hosting host

[mawinter69]

• https://github.com/Yakshna-Corporation/testwheel-trigger/blob/f1893ac77fc9b01899b52ac09186e40c230eb92e/pom.xml#L18 I would not skip test execution
• https://github.com/Yakshna-Corporation/testwheel-trigger/blob/f1893ac77fc9b01899b52ac09186e40c230eb92e/pom.xml#L31-34 the urls should point to the jenkinsci organization as your plugin will live there.
• you should add an url tag with <url>https://github.com/jenkinsci/testwheel-trigger-plugin</url> after line 15 in your pom. This ensures that the plugin site at https://plugins.jenins.io finds the README.md and shows it there as the description
• https://github.com/Yakshna-Corporation/testwheel-trigger/blob/main/src/main/resources/index.jelly should be shorter and not contain a longer explanation. This file is what is shown in the plugin manager in Jenkins where you will also get a link to https://plugins.jenkins.io`. I think just having Automate TestWheel framework tests in CI/CD pipelines with seamless integration and continuous validation. is enough.
• I think it would be good if you add a .github and a .mvn folder with the contents that you get when you create a sample Jenkins plugin with the maven archetype (see https://www.jenkins.io/doc/developer/tutorial/create/). You need them when you go for automatic plugin releases (https://www.jenkins.io/doc/developer/publishing/releasing-cd/)

PS: No need to write /hosting host everytime. You're not able to execute this

[prakashp1987]

@mawinter69


scm:git:https://github.com/jenkinsci/testwheel-trigger-plugin.git


scm:git:https://github.com/jenkinsci/testwheel-trigger-plugin.git

https://github.com/jenkinsci/testwheel-trigger-plugin
HEAD
will this address your suggestion on "the urls should point to the jenkinsci organization as your plugin will live there."

Secondly, i am not sure whether .github & .mvn is mandatory?

[prakashp1987]

@mawinter69
index.jelly as per your suggestion. i removed other contents and kept the support section alone for users to contact us.

/hosting re-check

[mawinter69]

Please also remove the support section. That should be in the README.md
Also remove the <h1>...
So just

<?jelly escape-by-default='true'?>
<div>
  Automate TestWheel framework tests in CI/CD pipelines with seamless integration and continuous validation.
</div>

is sufficient.

.github and .mvn are not mandatory. But what is added from the archetype is for example the security scan workflow, that will trigger a security each time you open a PR which I think is a real value

[prakashp1987]

@mawinter69
Updated the index.jelly file as per your suggestion. Regarding the .github & .mvn folder, we will update the same during our upcoming version upgrades of plugin. Kindly proceed with the hosting request of our plugin.

/hosting re-check

[mawinter69]

/hosting re-check

[github-actions]

Hello from your friendly Jenkins Hosting Checker

It looks like you have everything in order for your hosting request. A member of the Jenkins hosting team will check over things that I am not able to check(code review, README content, etc) and process the request as quickly as possible. Thank you for your patience.

Hosting team members can host this request with /hosting host

[mawinter69]

/hosting host

[mawinter69]

One minor thing that you can update later:
the .gitignore could need an update. Recommend to use the one from the archetype https://github.com/jenkinsci/archetypes/blob/master/common-files/gitignore

[jenkins-infra-bot]

Hosting request complete, the code has been forked into the jenkinsci project on GitHub as https://github.com/jenkinsci/testwheel-trigger-plugin

GitHub issues has been selected for issue tracking and was enabled for the forked repo.

A pull request has been created against the repository permissions updater to setup release permissions. Additional users can be added by modifying the created file.

Please delete your original repository (if there are no other forks), under 'Danger Zone', so that the jenkinsci organization repository is the definitive source for the code. If there are other forks, please contact GitHub support to make the jenkinsci repo the root of the fork network (mention that Jenkins approval was given in support request 569994). Also, please make sure you properly follow the documentation on documenting your plugin so that your plugin is correctly documented.

You will also need to do the following in order to push changes and release your plugin:

• Accept the invitation to the Jenkins CI Org on Github
• Add additional users for upload permissions, if needed
• Releasing your plugin

Welcome aboard!

[prakashp1987]

@mawinter69
I need your support in Plugin Release. I need the release steps and guidance in releasing the plugin for our web users to make use of it in their deployment pipeline

[mawinter69]

https://www.jenkins.io/doc/developer/publishing/releasing-manually/