From ede6ef42b40748fb4e6459ce99299470e25256f8 Mon Sep 17 00:00:00 2001 From: =?UTF-8?q?Fernando=20Fern=C3=A1ndez?= Date: Tue, 10 Sep 2024 18:30:51 +0000 Subject: [PATCH 1/5] feat(clients/vue): create deployment documentation Signed-off-by: GitHub --- docs/general/clients/jellyfin-vue.md | 227 +++++++++++++++++++++++++++ 1 file changed, 227 insertions(+) create mode 100644 docs/general/clients/jellyfin-vue.md diff --git a/docs/general/clients/jellyfin-vue.md b/docs/general/clients/jellyfin-vue.md new file mode 100644 index 000000000..9da9741cb --- /dev/null +++ b/docs/general/clients/jellyfin-vue.md @@ -0,0 +1,227 @@ +--- +uid: jellyfin-vue +title: Jellyfin Vue +--- +# Jellyfin Vue + +[Jellyfin Vue](https://github.com/jellyfin/jellyfin-vue) is an experimental, alternative browser-based web client for Jellyfin written using Vue.js. + +:::note +Jellyfin Vue is not planned or targeted to replace the main Jellyfin Web client, and is not feature-complete. +::: + +Below are concise instructions to get your own instance of Jellyfin Vue up and running. +If you identify with at least one of the following options: + +* Want to try it as quickly as possible for the first time +* Are not sure whether you need to deploy your own instance +* Don't need to go beyond user customization to change app-wide behaviour. +* Have a [reverse proxy](../networking/index.md) and a working HTTPS setup. + +You're probably better using [our hosted instance](https://jf-vue.pages.dev). +More info at [Jellyfin Vue's repository](https://github.com/jellyfin/jellyfin-vue). + +# Deployment + +:::caution +Since Jellyfin Vue is just an interface for a Jellyfin server, all of these instructions assume that you already have one up and running. +[Set it up now](../installation/index.mdx) if you haven't already. +::: + +## RECOMMENDED: Using Docker + +:::info +* In case you don't have Docker, follow [the official installation guide](https://docs.docker.com/engine/install) first. +Learning about [Compose](https://docs.docker.com/compose) is also recommended. +* Docker Compose is now shipped with Docker, so you don't need to install it. It's recommended that you uninstall +the old `docker-compose`. +* [`version` key is deprecated](https://docs.docker.com/reference/compose-file/version-and-name/#version-top-level-element-obsolete) +in Docker Compose, hence not included below. +::: + +We're going to use the following `docker-compose.yml` as an starting point: + +```yaml +services: + jellyfin_vue: + container_name: jellyfin_vue + image: ghcr.io/jellyfin/jellyfin-vue:unstable + restart: always + ports: + - 8080:80 + labels: + - "com.centurylinklabs.watchtower.enable=true" + + watchtower: + container_name: watchtower + image: ghcr.io/containrrr/watchtower + volumes: + - /var/run/docker.sock:/var/run/docker.sock + environment: + TZ: Europe/Madrid + WATCHTOWER_CLEANUP: 1 + WATCHTOWER_INCLUDE_RESTARTING: 1 + WATCHTOWER_POLL_INTERVAL: 60 + WATCHTOWER_LABEL_ENABLE: 1 + # Needed so watchtower doesn't restart-loop when updating itself + restart: on-failure +``` + + +:::success +Getting things up and running is as easy as doing `docker compose up` with your terminal +located where the `docker-compose.yml` file is. +::: + +With this compose file: + +- Jellyfin Vue will be accessible on `8080` port of the machine that's running the containers +- Watchtower takes care of updating the container to the latest commit available on the [repository](https://github.com/jellyfin/jellyfin-vue). +This is a good idea because: + * As of now, stable releases don't exist and there have only been prereleases that don't necessarily meet a quality criteria, but + [major development milestones](https://jellyfin.org/posts/vue-vue3/). + * Only the latest `unstable` image is supported. + +After accessing the instance in your browser of choice, you'll be prompted to add a server. You can use your own server or our demo +instance, located at `https://demo.jellyfin.org/stable` + +:::note +The server address you need to type is relative to the device you're accessing Jellyfin Vue. For instance, +if your Jellyfin Server is located at 192.168.0.10 and you have deployed Jellyfin Vue to that same server, +and your client is 192.168.0.20, the address you need to input is `http://192.168.0.10`, not +`http://127.0.0.1` or `http://localhost`. + +You can learn more about how the connection to your server works +[in Jellyfin's Vue repository privacy disclaimer](https://github.com/jellyfin/jellyfin-vue#privacy-disclaimer-) +::: + +### Using environment variables + +This is an example on how environment variables are set in the container by adding the +following keys to the `jellyfin_vue` definition in [above's](#recommended-using-docker-compose) `docker-compose.yml`: + +```yaml +environment: + HISTORY_ROUTER_MODE: 1 +``` + +See the [complete reference of environment variables available](https://github.com/jellyfin/jellyfin-vue/wiki/Configuration) +to further customize Jellyfin Vue to your liking at Jellyfin Vue's wiki. + +### Using your own webserver + +Since Jellyfin Vue is an SPA web application, you can use any webserver to serve it: +Apache, nginx (the one used in Jellyfin's Vue docker image), Traefik, etc... + +If you already have a [reverse proxy](../networking/index.md) set up, do you want to do more complex stuff +that it's out of the scope of this documentation like serving at a subpath, in another subdomain, etc..., +you might want to have Jellyfin Vue served by your own webserver instead of the nginx instance shipped with +the Docker image. + +To achieve that, in the `jellyfin_vue` service definition of the `docker-compose.yml` shown [above](#recommended-using-docker-compose): +* Remove the `ports` key. +* Add the following keys, **replacing** `_path_` **with the folder** where your webserver expects Jellyfin Vue's assets: + +```yaml +network_mode: none +volumes: + - _𝘱𝘒𝘡𝘩_:/dest +# This makes the container do nothing and sleep forever, +# frontend will be copied to _𝘱𝘒𝘡𝘩_ and will be served by your webserver +# /setup.sh applies +entrypoint: /bin/sh -c '/setup.sh && rm -rf /dest/* && cp -r /usr/share/nginx/html/* /dest && sleep infinity' + +``` + +This approach: +* Keeps the client always updated in a hassle-free way, as explained [above](#recommended-using-docker-compose). +* In case you use [environment variables](#using-environment-variables), +they will still be applied. + + +### Replacing Jellyfin Web + +:::danger +Be aware that some clients, like Android (not TV) and Jellyfin Media Player expects that your Jellyfin server +has Jellyfin Web served alongisde its API, so they will stop working if you go ahead. +::: + +We will follow the same approach we used [in the previous section](#using-your-own-webserver) but we +can approach this in two different ways: + +* Change the directory from where Jellyfin Server serves Jellyfin Web to your own path. + * This approach has the advantage that keeps the rest of your setup intact,making it easy to recover it in case it's needed + * See [here](../administration/configuration.md#web-directory) to find how its location is determined + and how to change it + +* Replace Jellyfin Web entirely + 1) Go to Server Dashboard > Paths in Jellyfin Web to find the route. + 2) Stop Jellyfin Server. + 3) **In Debian/Ubuntu**: Uninstall the package with `sudo apt remove jellyfin-web` + 4) Follow [the previous section](#using-environment-variables) procedure, + using the path obtained in the first step. + + + +If you ever want to get Jellyfin Web back, revert those changesbuild the specific version you want from their repository +and put the built assets in the corresponding directo + +:::info +Even if you follow this procedure correctly, Jellyfin Web might still load, since stale cache might persist in your browser. +Clear your browser's cache or try in private browsing to make sure that you did everything correctly. +::: + +:::success +Given not all administrator options are available in Jellyfin Vue, you might need to use Jellyfin Web +at some point to change some settings. + +Jellyfin Web has [its own hosted instance](https://jellyfin-web.pages.dev) +([in the same way as Jellyfin Vue](https://jf-vue.pages.dev)) pointing to the +latest commit from its default branch that you can access at any time if you ever need it +again. +::: + +## Manually + +:::caution +Make sure you understand [the implications](#why-updates-needed) before using these methods first. +None of them are supported by Jellyfin Vue. +::: + +### `docker run` + +In case you don't want to use Docker Compose or automated updates, but still use Docker, this command is enough: + +```bash +docker run -d -p 8080:80 ghcr.io/jellyfin/jellyfin-vue:unstable +``` + +### From source / build output + +:::info +This might not be necessary if you just want to test a Pull Request. +Check [these instructions instead](../testing/web/index.md) +::: + +:::danger +By default, never trust any assets given by anyone outside the official channels if you can't inspect the source code first. +They might compromise or trace your activity! +::: + +Since Jellyfin Vue is a web application, using it it's a matter of setting up your own webserver +and pointing it to Jellyfin Vue's assets. You can get them: + +* By building your own version from our source. The repository's [wiki](https://github.com/jellyfin/jellyfin-vue/wiki) +has instructions for setting up the development environment. +* By getting them from [GitHub's Actions artifacts](https://github.com/jellyfin/jellyfin-vue/actions). + * Although those artifacts are built in our repository's CI/CD, + **some runs are sourced from Pull Requests created by external contributors that might not be good actors!** + * All artifacts generated by GitHub Actions are [built with provenances](https://github.com/jellyfin/jellyfin-vue/attestations). + * Our official Docker image is built from GitHub Actions and all the process is transparent and can be audited. + +## Other documentation + +* The rest of the documentation about Jellyfin Vue can be found on it's [wiki](https://github.com/jellyfin/jellyfin-vue/wiki). + +* You can check [GitHub Packages (GHCR)](https://github.com/jellyfin/jellyfin-vue/pkgs/container/jellyfin-vue) (recommended) +or [DockerHub](https://hub.docker.com/r/jellyfin/jellyfin-vue) for all the tagged Docker images. From b87eae6573031481fe242c452a0704a94386c501 Mon Sep 17 00:00:00 2001 From: =?UTF-8?q?Fernando=20Fern=C3=A1ndez?= Date: Tue, 10 Sep 2024 18:44:22 +0000 Subject: [PATCH 2/5] feat(testing/web): add security disclaimer Signed-off-by: GitHub --- docs/general/testing/web/index.md | 8 ++++++++ 1 file changed, 8 insertions(+) diff --git a/docs/general/testing/web/index.md b/docs/general/testing/web/index.md index 4160c0e44..2f23377a7 100644 --- a/docs/general/testing/web/index.md +++ b/docs/general/testing/web/index.md @@ -26,3 +26,11 @@ Each pull request of [Jellyfin Web](https://github.com/jellyfin/jellyfin-web) an :::caution Using a development version of clients may lead to data corruption or loss on the server. Please use a dedicated test server and make regular backups of [Jellyfin files](/docs/general/administration/configuration#server-paths). ::: + +:::danger +Although CloudFlare Pages deployments from Pull Requests are built in our CI/CD workflow +in a completely transparent and auditable manner, **some of them may come from external contributors that might not be good actors!**. + +By default, never trust any artifacts given by anyone outside the official channels if you can't inspect the source code first. +They might compromise or trace your activity! +::: From e23326b6c32507424df1c205bde4dc834ea868cb Mon Sep 17 00:00:00 2001 From: =?UTF-8?q?Fernando=20Fern=C3=A1ndez?= Date: Wed, 11 Sep 2024 11:03:03 +0000 Subject: [PATCH 3/5] refactor(client/vue): address review comments Signed-off-by: GitHub --- docs/general/clients/jellyfin-vue.md | 53 +++------------------------- 1 file changed, 4 insertions(+), 49 deletions(-) diff --git a/docs/general/clients/jellyfin-vue.md b/docs/general/clients/jellyfin-vue.md index 9da9741cb..dc2e8be68 100644 --- a/docs/general/clients/jellyfin-vue.md +++ b/docs/general/clients/jellyfin-vue.md @@ -13,10 +13,10 @@ Jellyfin Vue is not planned or targeted to replace the main Jellyfin Web client, Below are concise instructions to get your own instance of Jellyfin Vue up and running. If you identify with at least one of the following options: -* Want to try it as quickly as possible for the first time -* Are not sure whether you need to deploy your own instance +* Want to try it quickly for the first time +* Are not sure whether you want to deploy your own instance * Don't need to go beyond user customization to change app-wide behaviour. -* Have a [reverse proxy](../networking/index.md) and a working HTTPS setup. +* Have a working HTTPS setup. You're probably better using [our hosted instance](https://jf-vue.pages.dev). More info at [Jellyfin Vue's repository](https://github.com/jellyfin/jellyfin-vue). @@ -24,20 +24,18 @@ More info at [Jellyfin Vue's repository](https://github.com/jellyfin/jellyfin-vu # Deployment :::caution -Since Jellyfin Vue is just an interface for a Jellyfin server, all of these instructions assume that you already have one up and running. +Since Jellyfin Vue is just an interface for a Jellyfin server, all of these instructions assume that you already have a server up and running. [Set it up now](../installation/index.mdx) if you haven't already. ::: ## RECOMMENDED: Using Docker -:::info * In case you don't have Docker, follow [the official installation guide](https://docs.docker.com/engine/install) first. Learning about [Compose](https://docs.docker.com/compose) is also recommended. * Docker Compose is now shipped with Docker, so you don't need to install it. It's recommended that you uninstall the old `docker-compose`. * [`version` key is deprecated](https://docs.docker.com/reference/compose-file/version-and-name/#version-top-level-element-obsolete) in Docker Compose, hence not included below. -::: We're going to use the following `docker-compose.yml` as an starting point: @@ -138,49 +136,6 @@ This approach: * In case you use [environment variables](#using-environment-variables), they will still be applied. - -### Replacing Jellyfin Web - -:::danger -Be aware that some clients, like Android (not TV) and Jellyfin Media Player expects that your Jellyfin server -has Jellyfin Web served alongisde its API, so they will stop working if you go ahead. -::: - -We will follow the same approach we used [in the previous section](#using-your-own-webserver) but we -can approach this in two different ways: - -* Change the directory from where Jellyfin Server serves Jellyfin Web to your own path. - * This approach has the advantage that keeps the rest of your setup intact,making it easy to recover it in case it's needed - * See [here](../administration/configuration.md#web-directory) to find how its location is determined - and how to change it - -* Replace Jellyfin Web entirely - 1) Go to Server Dashboard > Paths in Jellyfin Web to find the route. - 2) Stop Jellyfin Server. - 3) **In Debian/Ubuntu**: Uninstall the package with `sudo apt remove jellyfin-web` - 4) Follow [the previous section](#using-environment-variables) procedure, - using the path obtained in the first step. - - - -If you ever want to get Jellyfin Web back, revert those changesbuild the specific version you want from their repository -and put the built assets in the corresponding directo - -:::info -Even if you follow this procedure correctly, Jellyfin Web might still load, since stale cache might persist in your browser. -Clear your browser's cache or try in private browsing to make sure that you did everything correctly. -::: - -:::success -Given not all administrator options are available in Jellyfin Vue, you might need to use Jellyfin Web -at some point to change some settings. - -Jellyfin Web has [its own hosted instance](https://jellyfin-web.pages.dev) -([in the same way as Jellyfin Vue](https://jf-vue.pages.dev)) pointing to the -latest commit from its default branch that you can access at any time if you ever need it -again. -::: - ## Manually :::caution From 21ebd93869f03e45478041bd7caeea0fd761c9ff Mon Sep 17 00:00:00 2001 From: =?UTF-8?q?Fernando=20Fern=C3=A1ndez?= Date: Wed, 11 Sep 2024 11:13:48 +0000 Subject: [PATCH 4/5] refactor(clients/vue): fix lint The hashtag at the beginning makes possible that Docusaurus still renders the page's title, rendering the rest of the headers at h2< size, which is needed to keep a better distinction between the different sections Signed-off-by: GitHub --- docs/general/clients/jellyfin-vue.md | 35 +++++++++++++++------------- 1 file changed, 19 insertions(+), 16 deletions(-) diff --git a/docs/general/clients/jellyfin-vue.md b/docs/general/clients/jellyfin-vue.md index dc2e8be68..880fa1f25 100644 --- a/docs/general/clients/jellyfin-vue.md +++ b/docs/general/clients/jellyfin-vue.md @@ -2,7 +2,7 @@ uid: jellyfin-vue title: Jellyfin Vue --- -# Jellyfin Vue +## [Jellyfin Vue](https://github.com/jellyfin/jellyfin-vue) is an experimental, alternative browser-based web client for Jellyfin written using Vue.js. @@ -21,14 +21,14 @@ If you identify with at least one of the following options: You're probably better using [our hosted instance](https://jf-vue.pages.dev). More info at [Jellyfin Vue's repository](https://github.com/jellyfin/jellyfin-vue). -# Deployment +# Deployment # :::caution Since Jellyfin Vue is just an interface for a Jellyfin server, all of these instructions assume that you already have a server up and running. [Set it up now](../installation/index.mdx) if you haven't already. ::: -## RECOMMENDED: Using Docker +## RECOMMENDED: Using Docker ## * In case you don't have Docker, follow [the official installation guide](https://docs.docker.com/engine/install) first. Learning about [Compose](https://docs.docker.com/compose) is also recommended. @@ -64,6 +64,7 @@ services: # Needed so watchtower doesn't restart-loop when updating itself restart: on-failure ``` + :::success @@ -73,12 +74,12 @@ located where the `docker-compose.yml` file is. With this compose file: -- Jellyfin Vue will be accessible on `8080` port of the machine that's running the containers -- Watchtower takes care of updating the container to the latest commit available on the [repository](https://github.com/jellyfin/jellyfin-vue). +* Jellyfin Vue will be accessible on `8080` port of the machine that's running the containers +* Watchtower takes care of updating the container to the latest commit available on the [repository](https://github.com/jellyfin/jellyfin-vue). This is a good idea because: - * As of now, stable releases don't exist and there have only been prereleases that don't necessarily meet a quality criteria, but + * As of now, stable releases don't exist and there have only been prereleases that don't necessarily meet a quality criteria, but [major development milestones](https://jellyfin.org/posts/vue-vue3/). - * Only the latest `unstable` image is supported. + * Only the latest `unstable` image is supported. After accessing the instance in your browser of choice, you'll be prompted to add a server. You can use your own server or our demo instance, located at `https://demo.jellyfin.org/stable` @@ -93,10 +94,10 @@ You can learn more about how the connection to your server works [in Jellyfin's Vue repository privacy disclaimer](https://github.com/jellyfin/jellyfin-vue#privacy-disclaimer-) ::: -### Using environment variables +### Using environment variables ### This is an example on how environment variables are set in the container by adding the -following keys to the `jellyfin_vue` definition in [above's](#recommended-using-docker-compose) `docker-compose.yml`: +following keys to the `jellyfin_vue` definition in [above's](#recommended-using-docker) `docker-compose.yml`: ```yaml environment: @@ -106,7 +107,7 @@ environment: See the [complete reference of environment variables available](https://github.com/jellyfin/jellyfin-vue/wiki/Configuration) to further customize Jellyfin Vue to your liking at Jellyfin Vue's wiki. -### Using your own webserver +### Using your own webserver ### Since Jellyfin Vue is an SPA web application, you can use any webserver to serve it: Apache, nginx (the one used in Jellyfin's Vue docker image), Traefik, etc... @@ -116,7 +117,8 @@ that it's out of the scope of this documentation like serving at a subpath, in a you might want to have Jellyfin Vue served by your own webserver instead of the nginx instance shipped with the Docker image. -To achieve that, in the `jellyfin_vue` service definition of the `docker-compose.yml` shown [above](#recommended-using-docker-compose): +To achieve that, in the `jellyfin_vue` service definition of the `docker-compose.yml` shown [above](#recommended-using-docker): + * Remove the `ports` key. * Add the following keys, **replacing** `_path_` **with the folder** where your webserver expects Jellyfin Vue's assets: @@ -132,18 +134,19 @@ entrypoint: /bin/sh -c '/setup.sh && rm -rf /dest/* && cp -r /usr/share/nginx/ht ``` This approach: -* Keeps the client always updated in a hassle-free way, as explained [above](#recommended-using-docker-compose). + +* Keeps the client always updated in a hassle-free way, as explained [above](#recommended-using-docker). * In case you use [environment variables](#using-environment-variables), they will still be applied. -## Manually +## Manually ## :::caution Make sure you understand [the implications](#why-updates-needed) before using these methods first. None of them are supported by Jellyfin Vue. ::: -### `docker run` +### `docker run` ### In case you don't want to use Docker Compose or automated updates, but still use Docker, this command is enough: @@ -151,7 +154,7 @@ In case you don't want to use Docker Compose or automated updates, but still use docker run -d -p 8080:80 ghcr.io/jellyfin/jellyfin-vue:unstable ``` -### From source / build output +### From source / build output ### :::info This might not be necessary if you just want to test a Pull Request. @@ -174,7 +177,7 @@ has instructions for setting up the development environment. * All artifacts generated by GitHub Actions are [built with provenances](https://github.com/jellyfin/jellyfin-vue/attestations). * Our official Docker image is built from GitHub Actions and all the process is transparent and can be audited. -## Other documentation +## Other documentation ## * The rest of the documentation about Jellyfin Vue can be found on it's [wiki](https://github.com/jellyfin/jellyfin-vue/wiki). From 49ea0e3516dbe4af5f8982896448f7a8de1c993c Mon Sep 17 00:00:00 2001 From: =?UTF-8?q?Fernando=20Fern=C3=A1ndez?= Date: Wed, 11 Sep 2024 20:26:55 +0200 Subject: [PATCH 5/5] refactor: address review comments MIME-Version: 1.0 Content-Type: text/plain; charset=UTF-8 Content-Transfer-Encoding: 8bit Co-authored-by: Niels van Velzen Co-authored-by: Gauvino <68083474+Gauvino@users.noreply.github.com> Co-authored-by: Odd StrΓ₯bΓΈ --- docs/general/clients/jellyfin-vue.md | 20 ++++++++++---------- docs/general/testing/web/index.md | 4 ++-- 2 files changed, 12 insertions(+), 12 deletions(-) diff --git a/docs/general/clients/jellyfin-vue.md b/docs/general/clients/jellyfin-vue.md index 880fa1f25..8c1fde0f9 100644 --- a/docs/general/clients/jellyfin-vue.md +++ b/docs/general/clients/jellyfin-vue.md @@ -37,7 +37,7 @@ the old `docker-compose`. * [`version` key is deprecated](https://docs.docker.com/reference/compose-file/version-and-name/#version-top-level-element-obsolete) in Docker Compose, hence not included below. -We're going to use the following `docker-compose.yml` as an starting point: +We're going to use the following `docker-compose.yml` as a starting point: ```yaml services: @@ -68,7 +68,7 @@ services: :::success -Getting things up and running is as easy as doing `docker compose up` with your terminal +Getting things up and running is as easy as doing `docker compose up -d` with your terminal located where the `docker-compose.yml` file is. ::: @@ -96,8 +96,8 @@ You can learn more about how the connection to your server works ### Using environment variables ### -This is an example on how environment variables are set in the container by adding the -following keys to the `jellyfin_vue` definition in [above's](#recommended-using-docker) `docker-compose.yml`: +This is an example of how environment variables are set in the container by adding the +following keys to the `jellyfin_vue` definition in [the above `docker-compose.yml`](#recommended-using-docker): ```yaml environment: @@ -109,7 +109,7 @@ to further customize Jellyfin Vue to your liking at Jellyfin Vue's wiki. ### Using your own webserver ### -Since Jellyfin Vue is an SPA web application, you can use any webserver to serve it: +Since Jellyfin Vue is an SPA web application, you can use any web server to serve it: Apache, nginx (the one used in Jellyfin's Vue docker image), Traefik, etc... If you already have a [reverse proxy](../networking/index.md) set up, do you want to do more complex stuff @@ -117,17 +117,17 @@ that it's out of the scope of this documentation like serving at a subpath, in a you might want to have Jellyfin Vue served by your own webserver instead of the nginx instance shipped with the Docker image. -To achieve that, in the `jellyfin_vue` service definition of the `docker-compose.yml` shown [above](#recommended-using-docker): +To achieve that, in the `jellyfin_vue` service definition of the [`docker-compose.yml` shown above](#recommended-using-docker): * Remove the `ports` key. -* Add the following keys, **replacing** `_path_` **with the folder** where your webserver expects Jellyfin Vue's assets: +* Add the following keys, **replacing** `_path_` **with the folder** where your web server expects Jellyfin Vue's assets: ```yaml network_mode: none volumes: - _𝘱𝘒𝘡𝘩_:/dest # This makes the container do nothing and sleep forever, -# frontend will be copied to _𝘱𝘒𝘡𝘩_ and will be served by your webserver +# frontend will be copied to _𝘱𝘒𝘡𝘩_ and will be served by your web server # /setup.sh applies entrypoint: /bin/sh -c '/setup.sh && rm -rf /dest/* && cp -r /usr/share/nginx/html/* /dest && sleep infinity' @@ -163,10 +163,10 @@ Check [these instructions instead](../testing/web/index.md) :::danger By default, never trust any assets given by anyone outside the official channels if you can't inspect the source code first. -They might compromise or trace your activity! +They might compromise your system or track your activity! ::: -Since Jellyfin Vue is a web application, using it it's a matter of setting up your own webserver +Since Jellyfin Vue is a web application, using it it's a matter of setting up your own web server and pointing it to Jellyfin Vue's assets. You can get them: * By building your own version from our source. The repository's [wiki](https://github.com/jellyfin/jellyfin-vue/wiki) diff --git a/docs/general/testing/web/index.md b/docs/general/testing/web/index.md index 2f23377a7..e2e66923b 100644 --- a/docs/general/testing/web/index.md +++ b/docs/general/testing/web/index.md @@ -28,9 +28,9 @@ Using a development version of clients may lead to data corruption or loss on th ::: :::danger -Although CloudFlare Pages deployments from Pull Requests are built in our CI/CD workflow +Although Cloudflare Pages deployments from Pull Requests are built into our CI/CD workflow in a completely transparent and auditable manner, **some of them may come from external contributors that might not be good actors!**. By default, never trust any artifacts given by anyone outside the official channels if you can't inspect the source code first. -They might compromise or trace your activity! +They might compromise your system or track your activity! :::