Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Create an "Uninstaller" #36

Closed
anthonylavado opened this issue Jun 2, 2020 · 6 comments · Fixed by #54
Closed

Create an "Uninstaller" #36

anthonylavado opened this issue Jun 2, 2020 · 6 comments · Fixed by #54
Labels
enhancement New feature or request

Comments

@anthonylavado
Copy link
Member

The current .app places config files in a few separate locations, all of them standard as per XDG Locations (see jellyfin/jellyfin#698).
These folders are typically hidden as macOS hides dot-files by default. We should create an uninstaller that can cleanly delete these.
This could also serve as a basis for a configuration backup/restore tool to assist with #35.

@anthonylavado anthonylavado added the enhancement New feature or request label Jun 2, 2020
@anthonylavado anthonylavado changed the title Create An "Uninstaller" Create an "Uninstaller" Jun 2, 2020
@brabs27
Copy link

brabs27 commented Jun 15, 2020

Hi Anthony, I’ve had to uninstall due to issues with android tv app. Which files do I need to delete that adding app to trash doesn’t delete.
Cheers

@LePips
Copy link
Member

LePips commented Aug 4, 2022

An uninstaller isn't the way to go, we may just have to change the paths to somewhere else. Is that possible with the executable?

@anthonylavado
Copy link
Member Author

We can specify every single path with arguments to the executable (like I do for jellyfin-web). The issue is that changing them now would require a migration for all future "upgrades".

@LePips
Copy link
Member

LePips commented Aug 8, 2022

Good point, but it's a trivial task to check paths, copy, and delete the old ones to migrate.

@LePips
Copy link
Member

LePips commented Aug 8, 2022

Additionally, I'll be aggregating the contents to ~/Library/Application Support/Jellyfin so we can just provide a proper Uninstall guide in this repo with the step to just delete that folder.

@anthonylavado
Copy link
Member Author

Alright, I dig it 🤠👍

@LePips LePips mentioned this issue Aug 9, 2022
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
enhancement New feature or request
Projects
None yet
Development

Successfully merging a pull request may close this issue.

3 participants