-
-
Notifications
You must be signed in to change notification settings - Fork 146
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Live TV player crashes to home screen for certain channels #2043
Comments
The error message is correct - rokus don't support HE-AAC (only v2). The server doesn't support converting one AAC profile to another, so I have HE-AAC being converted to MP3 #1963 1963 only triggers when the container is ts or mp4 https://github.com/jellyfin/jellyfin-roku/pull/1963/files#diff-944396a3daefd786f2db28996ea075470a1e36b59c973c3001853d8dcafdc4adR50 I noticed in your log that the input file is from a URL. I only use local files and I don't use live tv so I'm not much help. I tried to download the file myself but there was no file extension? Is it possible this file isn't triggering #1963 because of the files container? |
I did include that url only in the paste so that I can remove it more easily in the future... I don't think I want that link floating around long term. You can download VLC Media Player and chose "File > Open Network..." and paste that url, it streams perfectly fine. I have several other channels that work the same way, with no extension, and those channels do work perfectly in jellyfin roku and other clients. The logs seem to indicate that it's being recognized as a .ts if I'm reading the logs correctly. That's a good point about AAC in roku - surprising to me that roku doesn't support it but it makes sense. Given that, I think the transcoding should happen on the server, doing it on the client like in https://github.com/jellyfin/jellyfin-roku/pull/1963/files feels like it's just asking for trouble. It could also be the source of some audio synchronization issues I've observed where the audio can be slightly delayed compared to the video. Do you know if there's an issue I can follow in the jellyfin server repo to track AAC transcoding behavior? |
In the log file, I can see: `Container: "mpegts" The code added in #1963 specifically checks for |
Hopefully it was 1963 because that should be an easy fix. I don't have live tv so if one of you could test I would appreciate it #2047 |
I'm currently testing this. |
The fix in #2047 does not address the issue. Unfortunately, this will be a bigger fix to make it work. Issue: Proposed fix: |
@johnpc FYI, we're using the link of the offending channel to test. Feel free to remove it from the pastebin at this point. |
@johnpc this sounds crazy but I had a few minutes right now to look in to this some more and now I can't reproduce it. It appears to be transcoding correctly. It looks like my server upgraded to 10.10.2 this morning. I'm hesitant to say the server update fixed it, but can you re-try on your end with the latest server? |
@johnpc can you give us the url of a different tv channel that crashes with HE-AAC audio? The channel from the logs is now giving us an LC aac audio stream which direct plays as expected. Can message us on matrix or my email is my username at gmail.
|
Here's a link to another impacted channel: https://paste.jpc.io/snippet/bdbe7239-3667-4672-ae06-3c928dce3c3b |
You can delete all your logs now we're done testing. Thanks for the bug report |
Software Versions
Describe the bug
The Live TV player in the Jellyfin Roku app is experiencing crashes that return the user to the Jellyfin home screen. This issue occurs in two scenarios:
How To Reproduce
Expected behavior
I expect the Jellyfin Roku client to play the channel, which works well on jellyfin web, jellyfin android-tv, and vlc app.
Logs
Server logs at time of crash:
Jellyfin Client logs:
ffmpeg logs: https://paste.jpc.io/snippet/b30da9cc-4e89-43cd-9f34-62bcea8e972b
ffmpeg logs when invoked via android-tv app: https://paste.jpc.io/snippet/8e83be93-b2a5-42a3-aed9-0182266593eb
The main difference I see between the ffmpeg logs is that when invoked from the roku client, I see
whereas I don't see that from the android-tv client.
Screenshots
iPhone recording of the repro (I couldn't figure out how to screen record the roku without it being a headache): https://files.jpc.io/d/Yx2mW-IMG_7343.mov
Connection Information
Additional context
Playback info for affected channel when working on jellyfin web client:
Roku software info:
The text was updated successfully, but these errors were encountered: