Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Profiles tab missing on Jellyfin 10.9.2 #49

Open
EthanArmbrust opened this issue May 18, 2024 · 18 comments
Open

Profiles tab missing on Jellyfin 10.9.2 #49

EthanArmbrust opened this issue May 18, 2024 · 18 comments

Comments

@EthanArmbrust
Copy link

The tab to configure DLNA profiles is missing on the 10.9.2 Jellyfin web client.

10.8.13
dlna_10 8

10.9.2
dlna_10 9

@ethanzxlee
Copy link

workaround - if you have created custom profile in the older versions , they would be stored in your config directory config/dlna/user, so you can copy all the xml files to the new directory under plugins plugins/configurations/dlna/user and it should work like it used to be after restarting the server

@samson-fu
Copy link

Will the UI get back in the future? It is a very important setting.

@disgustipated
Copy link
Contributor

disgustipated commented Jun 12, 2024

I started crafting this up this morning locally to add a profiles tab similar to how it used to be. The Playback reporting plugin has a tabbed structure which I like and I was able to get the profiles tab to show like that plugin does on the dlna plugin page in my local environment. Lots more would need to be built out for this. Editing the xml files in the profiles folder in the plugin folder is a decent workaround.

i built a branch on my local repo with the profiles tab working in the plugin settings page. need to fill out the rest of the ui and controls for editing with how it used to look. mapped the below out from the old version. some of this could probably be cleaned up a bit and organized differently as the old ui wasnt very clear what you were editing.

profiles
    custom profiles
        lists custom profiles - were stored in user folder
    system profiles were stored in a system profiles folder
        lists out system profiles - clicking goes to editing the profile as a custom one

    editingprofile - dlnaprofile.html
        tabs - 
            info
                Name
                User Library
                supported media types
                maximum streaming quality
                music transcoding bitrate
                submenus
                    identification
                    display
                    image settings
                    server settings
                    subtitle profiles
                    xml settings
            direct playback - profiles that define container, video codec, audio codec
                NEW button
                video
                audio
                photo
            transcoding - settings holding transcoding options
                NEW button
                video 
                audio
                photo
            containers - Container profiles indicate the limitations of a device when playing specific formats. If a limitation applies then the media will be transcoded, even if the format is configured for direct playback.
            codecs - lists codecs for audio and video
                Video
                Video AUdio
            responses - Response profiles provide a way to customize information sent to the device when playing certain kinds of media.

@teranex
Copy link

teranex commented Jun 13, 2024

workaround - if you have created custom profile in the older versions , they would be stored in your config directory config/dlna/user, so you can copy all the xml files to the new directory under plugins plugins/configurations/dlna/user and it should work like it used to be after restarting the server

I can't seem to get this working. I use jellyfin on ubuntu 22.04. My configuration seems to be in /var/lib/jellyfin/plugins/configurations/. So I copied my xml file from the previous location to /var/lib/jellyfin/plugins/configurations/dlna and restarted jellyfin, but it still complains it's going to use the default DLNA configuration when I start playing on my AV.

Just to make sure I'm looking in the correct directory, I changed the Client Discovery Interval from 60 to 55 and saw indeed the change in that directory:

root@jellyfin:/var/lib/jellyfin/plugins/configurations# ll
drwxr-xr-x  3 jellyfin jellyfin 4096 May 14 17:16 dlna/
-rw-r--r--  1 jellyfin jellyfin  494 Jun 13 20:11 Jellyfin.Plugin.Dlna.xml

looking in Jellyfin.Plugin.Dlna.xml I then indeed see value 55 instead of 60.

@disgustipated
Copy link
Contributor

workaround - if you have created custom profile in the older versions , they would be stored in your config directory config/dlna/user, so you can copy all the xml files to the new directory under plugins plugins/configurations/dlna/user and it should work like it used to be after restarting the server

I can't seem to get this working. I use jellyfin on ubuntu 22.04. My configuration seems to be in /var/lib/jellyfin/plugins/configurations/. So I copied my xml file from the previous location to /var/lib/jellyfin/plugins/configurations/dlna and restarted jellyfin, but it still complains it's going to use the default DLNA configuration when I start playing on my AV.

Just to make sure I'm looking in the correct directory, I changed the Client Discovery Interval from 60 to 55 and saw indeed the change in that directory:

root@jellyfin:/var/lib/jellyfin/plugins/configurations# ll
drwxr-xr-x  3 jellyfin jellyfin 4096 May 14 17:16 dlna/
-rw-r--r--  1 jellyfin jellyfin  494 Jun 13 20:11 Jellyfin.Plugin.Dlna.xml

looking in Jellyfin.Plugin.Dlna.xml I then indeed see value 55 instead of 60.

What version are you on? I'm using latest with the plugin but I'm in docker, you should have something similar though. My profiles are stored inside /config/plugins/DLNA_2.0.0.0/profiles/

@KintsugiUwU

This comment has been minimized.

@disgustipated

This comment has been minimized.

@KintsugiUwU

This comment has been minimized.

@disgustipated

This comment has been minimized.

@Nullcaller
Copy link
Contributor

Any updates on this, @disgustipated? I kinda want to try and have a go at it, both because I want to utilize the functionality and for a little bit of fun. I don't want to be a nuisance, though, so if you're cooking up something cool, I'll wait.

@disgustipated
Copy link
Contributor

I have a branch in my fork that has the UI tab showing. There's a bunch of things that still need done though. This morning I started looking at some of where the profiles are stored and understand better where user profiles are and how the system profiles are used. In short, kinda getting there and I was thinking of starting to tackle that now that dlna is working well again. This is going to be a big task though, and I thought I saw some more work from the jf server project with how profiles are used there too so I wanted to look into what their plans were there.

@Nullcaller
Copy link
Contributor

May I try and help, i.e. fork your branch and try to bring some of the profile settings back? I found a PR in jellyfin-web that removed DLNA plugin settings, and it seemed to me like some of the code would probably be transferrable. API endpoints seem to still be there (though I haven't checked that thoroughly), so bringing back at least some of the old UI back appears to be an achievable goal. Then, I believe, it can be modified from there to be more betterer.

@disgustipated
Copy link
Contributor

disgustipated commented Oct 29, 2024

You're free to do whatever ya want 😁
When I looked at pulling in the old stuff I decided against it because it was an old way of reading the xml and i never liked how the ui elements looked to begin with, it always seemed all jumbled so that's why i wanted to write it from scratch.

@Nullcaller
Copy link
Contributor

Yeah, I agree the profiles UI needs some love... Just making a sanity check here, is my understanding correct that, most of the times, when you use device profiles, you leave most settings at default, and tweak only the few that you need?

@chmutoff
Copy link

I had to downgrade my Jellyfin to the version with profiles. I don't understand the logic. From the user perspective, I don't care what kind of old or new way of handling xml files is being used as long as I have all the functionality that I used to have. Making a "new and cool" version of a plugin with half of it's functionality is a huge downgrade, specially when the dlna mode is the mosltly used by tv users since the lg app is not available for old lg tvs and the samsung app still in development. I just don't understand why the DLNA did not move to a plugin in a state that it was originally and then just do a refactor or modify that code to be as perfect as it can be without destroying things. I really hope that some day this functionality will come back so I can update to the latest version of Jellyfin.

@SamHawkens
Copy link

dlna user transcoding profiles are not working for me now that dlna is a plugin either.

I copied my previously working profiles from
/etc/jellyfin/dlna/user/
to
/var/lib/jellyfin/plugins/configurations/dlna/user/

server is version 10.10.3 (native installation, not docker)

@SamHawkens
Copy link

I should have checked the log.

[ERR] Error parsing profile file: "/var/lib/jellyfin/plugins/configurations/dlna/user/iTuner 320 ME.xml"
System.InvalidOperationException: There is an error in XML document (42, 85).
---> System.InvalidOperationException: Instance validation error: '' is not a valid value for MediaStreamProtocol.

So at least jellyfin reads the profile. Any hint what's wrong here? It used to work before dlna became a plugin.

@disgustipated
Copy link
Contributor

@SamHawkens log a separate issue as its not related to this thread.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

No branches or pull requests

9 participants