Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Inconcistent Changes output types #381

Open
LordMike opened this issue Jul 8, 2021 · 0 comments
Open

Inconcistent Changes output types #381

LordMike opened this issue Jul 8, 2021 · 0 comments
Labels
enhancement

Comments

@LordMike
Copy link
Collaborator

LordMike commented Jul 8, 2021

From @mpfc75:

Thanks for your reply.
GetMovieChangesAsync returns Task<IList>
GetTvEpisodeChangesAsync returns Task<IList>
GetTvSeasonChangesAsync returns Task<IList>

GetTvShowChangesAsync returns Task (not IList).

These could all be of one form - as ChangesContainer wraps a List<Change>.
@LordMike LordMike mentioned this issue Jul 8, 2021
Closed
mpfc75 added a commit to mpfc75/TMDbLib that referenced this issue Jul 9, 2021
@mpfc75
Update TMDbClientTvShows.cs
384bd65 
Changes for jellyfin#381 and jellyfin#382. 

This change updates GetTvShowChangesAsync to:
1) (jellyfin#381) Changes returned type from Task<ChangesContainer> to Task<IList<Change>> to be consistent with GetTvSeasonChangesAsync, GetTvEpisodeChangesAsync, and GetMovieChangeAsync.
2) (jellyfin#382) Add missing startDate, endDate, and page parms
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Assignees
No one assigned
Labels
enhancement
Projects
None yet
Milestone
No milestone
Development

No branches or pull requests
1 participant
@LordMike