Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Nullable int Id in TMDbLib.Objects.TvShows.TvEpisodeInfo #376

Open
WolfgangRoggen opened this issue May 4, 2021 · 1 comment
Open

Nullable int Id in TMDbLib.Objects.TvShows.TvEpisodeInfo #376

WolfgangRoggen opened this issue May 4, 2021 · 1 comment

Comments

@WolfgangRoggen
Copy link

WolfgangRoggen commented May 4, 2021

You made the property: TMDbLib.Objects.TvShows.TvEpisodeInfo.Id nullable.
This seems not correct.
In my understanding the Id cant be null.
Same for: TMDbLib.Objects.TvShows.TvSeason.Id

Please have a look ainto the description of the Api.
Episode and Season have 2 Id's
one "string _id" and one "int id" (see underscore)

And afaik you have no Property for the string _id.

Regards
Wolfgang

@LordMike
Copy link
Collaborator

LordMike commented May 4, 2021

The missing _id is definitely a bug. But as for the nullable int - there is a risk that this may be because the object is used in two places. It may be that the other place doesn't provide an id.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

No branches or pull requests

2 participants