Fix metadata 403's and Add images to search results #54
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Musi13
commented
Mar 9, 2020
Musi13
commented
Mar 9, 2020
Musi13
changed the title
heyhippari
reviewed
Mar 9, 2020
Jellyfin.Plugin.Anime/Providers/AniDB/Identity/AniDbTitleDownloader.cs
Outdated
Show resolved
Hide resolved
dkanada
reviewed
Mar 9, 2020
Jellyfin.Plugin.Anime/Providers/AniDB/Identity/AniDbTitleDownloader.cs
Outdated
Show resolved
Hide resolved
oddstr13
reviewed
Mar 15, 2020
| { | ||
| static class Constants | ||
| { | ||
| public const string UserAgent = "jellyfin-plugin-anime"; |
There was a problem hiding this comment.
I would propose we use a more proper user-agent string, such as;
jellyfin-plugin-anime/5.0.0.0 (+https://github.com/jellyfin/jellyfin-plugin-anime/issues) Jellyfin/10.5.0
https://en.wikipedia.org/wiki/User_agent has examples of how browsers and bots behave in this regard
There was a problem hiding this comment.
Let's save that for another pull request. This is an improvement and I'm sure people want it working again after the update so I'll push a new version for now.
dkanada
approved these changes
Mar 15, 2020
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Somewhat recently it seems AniDB started responding with 403 when a request for the anime titles didn't include a User-Agent header (#50). This PR fixes that, so searching will re-download the anime titles and work again.
Additionally, since searching already involves querying for the full metadata of an anime, we can include ImageUrls in the results for free.
Screenshots