From e9bc4636466d5935cb5dda7a7829aed404a495b7 Mon Sep 17 00:00:00 2001 From: Kendall Garner <17521368+kgarner7@users.noreply.github.com> Date: Sat, 16 Sep 2023 17:31:01 -0700 Subject: [PATCH 1/3] fix other places of duration display --- src/main/features/linux/mpris.ts | 2 +- src/remote/components/remote-container.tsx | 2 +- 2 files changed, 2 insertions(+), 2 deletions(-) diff --git a/src/main/features/linux/mpris.ts b/src/main/features/linux/mpris.ts index 16c63c5fc..bc21595ce 100644 --- a/src/main/features/linux/mpris.ts +++ b/src/main/features/linux/mpris.ts @@ -145,7 +145,7 @@ ipcMain.on('update-song', (_event, args: SongUpdate) => { mprisPlayer.metadata = { 'mpris:artUrl': upsizedImageUrl, - 'mpris:length': song.duration ? Math.round((song.duration || 0) * 1e6) : null, + 'mpris:length': song.duration ? Math.round((song.duration || 0) * 1e3) : null, 'mpris:trackid': song.id ? mprisPlayer.objectPath(`track/${song.id?.replace('-', '')}`) : '', diff --git a/src/remote/components/remote-container.tsx b/src/remote/components/remote-container.tsx index b09b29d28..24a0154a2 100644 --- a/src/remote/components/remote-container.tsx +++ b/src/remote/components/remote-container.tsx @@ -45,7 +45,7 @@ export const RemoteContainer = () => { Artist: {song.artistName} - Duration: {formatDuration(song.duration * 1000)} + Duration: {formatDuration(song.duration)} {song.releaseDate && ( Released: {new Date(song.releaseDate).toLocaleDateString()} From 6037ef8952276069dd2d16d8f57f1c2e04c24ef8 Mon Sep 17 00:00:00 2001 From: Kendall Garner <17521368+kgarner7@users.noreply.github.com> Date: Sun, 17 Sep 2023 07:34:08 -0700 Subject: [PATCH 2/3] add back comma --- .../features/player/components/full-screen-player-image.tsx | 2 +- .../features/player/components/full-screen-player-queue.tsx | 2 +- 2 files changed, 2 insertions(+), 2 deletions(-) diff --git a/src/renderer/features/player/components/full-screen-player-image.tsx b/src/renderer/features/player/components/full-screen-player-image.tsx index 1d723ce66..26c33cbf5 100644 --- a/src/renderer/features/player/components/full-screen-player-image.tsx +++ b/src/renderer/features/player/components/full-screen-player-image.tsx @@ -42,7 +42,7 @@ interface TransparentMetadataContainer { const MetadataContainer = styled(Stack)<TransparentMetadataContainer>` padding: 1rem; - background: rgb(var(--main-bg-transparent) ${({ opacity }) => opacity}%); + background: rgb(var(--main-bg-transparent), ${({ opacity }) => opacity}%); border-radius: 5px; h1 { diff --git a/src/renderer/features/player/components/full-screen-player-queue.tsx b/src/renderer/features/player/components/full-screen-player-queue.tsx index f956547fc..e856cd63f 100644 --- a/src/renderer/features/player/components/full-screen-player-queue.tsx +++ b/src/renderer/features/player/components/full-screen-player-queue.tsx @@ -50,7 +50,7 @@ const GridContainer = styled.div<TransparendGridContainerProps>` grid-template-rows: auto minmax(0, 1fr); grid-template-columns: 1fr; padding: 1rem; - background: rgb(var(--main-bg-transparent) ${({ opacity }) => opacity}%); + background: rgb(var(--main-bg-transparent), ${({ opacity }) => opacity}%); border-radius: 5px; `; From bb0b260b0ee2a77182c71ae5249c1fd0d632044f Mon Sep 17 00:00:00 2001 From: Kendall Garner <17521368+kgarner7@users.noreply.github.com> Date: Mon, 18 Sep 2023 21:27:25 -0700 Subject: [PATCH 3/3] add max-width for image --- .../features/player/components/full-screen-player-image.tsx | 1 + 1 file changed, 1 insertion(+) diff --git a/src/renderer/features/player/components/full-screen-player-image.tsx b/src/renderer/features/player/components/full-screen-player-image.tsx index 26c33cbf5..870c22a21 100644 --- a/src/renderer/features/player/components/full-screen-player-image.tsx +++ b/src/renderer/features/player/components/full-screen-player-image.tsx @@ -24,6 +24,7 @@ const Image = styled(motion.img)<{ $useAspectRatio: boolean }>` object-position: 50% 100%; filter: drop-shadow(0 0 5px rgb(0 0 0 / 40%)) drop-shadow(0 0 5px rgb(0 0 0 / 40%)); border-radius: 5px; + max-width: 100%; `; const ImageContainer = styled(motion.div)`