Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

CSP violation in isemail #3

Open
dominics opened this issue May 11, 2016 · 4 comments
Open

CSP violation in isemail #3

dominics opened this issue May 11, 2016 · 4 comments

Comments

@dominics
Copy link

I wonder if you might consider merging a patch like lann/isemail@master...patch-1 ahead of upstream? Seems pretty safe to me, and it would let me turn unsafe-eval off in my CSP policy. 🎉

(Last activity on the upstream PR was December)

@jeffbski
Copy link
Owner

I'd prefer to see if we can get this merged into isemail so we don't stray from the main codeline, that could quickly become a maintenance nightmare.

I just posted a comment on the PR in isemail to see if we could get this merged. I think it just got forgotten about, so we need to awakend the discussion.

@jeffbski
Copy link
Owner

It looks like it is merged into isemail@master and should land in [email protected] so hopefully once it does then joi and joi-browser can pick it up.

skeggse/isemail#12

@idolizesc
Copy link

This was fixed, right?

@jeffbski
Copy link
Owner

@idolizesc I believe it was, so I have built the latest versions of joi-browser so it should pull in that fix.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

No branches or pull requests

3 participants