Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Ability to add environment variables #76

Open
rclai opened this issue Oct 6, 2015 · 4 comments
Open

Ability to add environment variables #76

rclai opened this issue Oct 6, 2015 · 4 comments

Comments

@rclai
Copy link
Contributor

rclai commented Oct 6, 2015

For example, be able to have a file that has the MONGO_URL, MONGO_OPLOG_URL which gets prepended to the meteor run command in the scripts.

FYI - these are different from the settings set in settings.json. See here. Yeah.. I know..

@AdamBrodzinski
Copy link
Collaborator

one thing we could do to make it easier to add env variables and make it easier for mup is to change the settings directory to something like below. Creating an env script would allow you to add in export MONGO_URL='foo' in the file and the startup script could source it before running Meteor.

renaming the settings file to settings.json would allow you to place a mup.json file in settings/prod/ and mup would pickup the settings.json file (needs that filename).

settings/
 ---devel/
    - settings.json
    - env.sh
 ---test/
    - settings.json
    - env.sh
 ---prod/
    - settings.json
    - env.sh

@jedwards1211
Copy link
Owner

This is why I need to make the core webpack-to-meteor stuff a drop-in package as I describe in #73 ...this isn't really a meteor/webpack specific issue, and I think focusing on providing the ideal app skeleton is unwise, rather than just providing an example app skeleton that's easy to tweak (without it being hard to keep up with bugfixes in the webpack-to-meteor part).

@AdamBrodzinski
Copy link
Collaborator

True, I think trying to handle every edge case will make it bloated. A drop in package would be cool.

@jedwards1211
Copy link
Owner

Hey guys, I just created a quick and dirty prototype of my drop-in webpack plugins. See https://github.com/jedwards1211/meteor-webpack-react/tree/webpack-meteor-tools and https://github.com/mindfront/webpack-meteor-tools

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

No branches or pull requests

3 participants