Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Error reading tmin data #4

Open
davidorme opened this issue Jul 8, 2022 · 0 comments
Open

Error reading tmin data #4

davidorme opened this issue Jul 8, 2022 · 0 comments

Comments

@davidorme
Copy link
Collaborator

I think nf90_inq_varid(ncid,'cld',varid) is a typo for nf90_inq_varid(ncid,'tmin',varid):

BIOME4/biome4driver.f90

Lines 249 to 255 in ff3d4ff

!-------------------------------------------------------
! absolute minimum temperature
tmin = -9999.
status = nf90_inq_varid(ncid,'cld',varid)
if (status == nf90_noerr) then ! tmin is present, we will read it from the file

If I'm following it right, because cld is mandatory, it will always be present at this point and then is read in as if it were tmin.

I have made this change in the adding_cli branch to see the effects - but I also realise that branch is suffering from mission creep. What would you like to happen with this - do you want the CLI version as the main line, in which case I can do a pull request or do you want the original interface on a parallel branch?

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

No branches or pull requests

1 participant