Skip to content
This repository has been archived by the owner on Jul 12, 2020. It is now read-only.

Better error checking for when fopen wrappers are disabled #229

Open
jeckman opened this issue Jul 19, 2017 · 1 comment
Open

Better error checking for when fopen wrappers are disabled #229

jeckman opened this issue Jul 19, 2017 · 1 comment

Comments

@jeckman
Copy link
Owner

jeckman commented Jul 19, 2017

Description

When using the server as a proxy, we depend on a readfile() with a url passed in. This is disallowed on some hosts. Would be better to check whether this is allowed and then present a better error message rather than just failing.

Steps to Reproduce

Try to use server as a proxy on a server where allow_url_fopen is not set in the php.ini or external file opening is not allowed.

Expected behavior:

Clear error message indicating what is wrong and what the user needs to do to fix it.

Actual behavior: [What actually happens]

Fails with other error messages / 0 size downloads.

Version

all versions to date, I think

Additional Information

Only true of the download using server as a proxy links - so direct browser download links unaffected.

@Art4
Copy link
Collaborator

Art4 commented Jul 20, 2017

A feature detection for readfile() would be really nice. Also for curl I think.

Repository owner deleted a comment from jedixraja Dec 27, 2018
Repository owner deleted a comment from jedixraja Dec 27, 2018
Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.
Projects
None yet
Development

No branches or pull requests

2 participants