Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Problem with fit historical #9

Open
ErMahdi opened this issue Mar 2, 2020 · 1 comment
Open

Problem with fit historical #9

ErMahdi opened this issue Mar 2, 2020 · 1 comment

Comments

@ErMahdi
Copy link

ErMahdi commented Mar 2, 2020

Hi, I'm a PhD student of water resource engineering, I'm trying to run your code for another reservoir system but when running the model in fit-historical mode, the storage values are way off, they seem to fluctuate around the mean observed storage data and not repeating the temporal pattern of storage, while in your paper you seem to have very good results. Did you use tocs when running the model for historical fit or optimization? Do you have any idea how can I fix the problem. Thanks in advance.
M.Erfani

@jdherman
Copy link
Owner

jdherman commented Mar 7, 2020

Hi @ErMahdi , sorry but I won't be able to help much with this if it's for another reservoir system. For the example in the paper, there are specific demand values and units that might not translate to a different system. Also yes, the historical fit in our paper was using the TOCS rule, but again that is specific to Folsom.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

No branches or pull requests

2 participants