Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Default Photometry File Requirements #5

Open
jenniferyee opened this issue Mar 25, 2024 · 5 comments
Open

Default Photometry File Requirements #5

jenniferyee opened this issue Mar 25, 2024 · 5 comments

Comments

@jenniferyee
Copy link
Collaborator

For MMEXOFAST, we need to choose a standard for photometry files, e.g. flux vs. magnitude. My opinion is that we should require:

Date (HJD), Flux, Flux Error

Date in HJD because most groups already report their dates that way.

Fluxes because we usually use difference imaging for the photometry, which means that the measured values can sometimes be negative. If we use magnitudes, this means that there needs to be a zeropoint and either some fraction of the negative fluxes will get eliminated (because you can't take the log of a negative number) or the magnitudes will be stupid (because your zeropoint is so large to accommodate the negative values that the dynamic range of the real flux changes is too small).

@rpoleski @jdeast I await your counter-arguments.

@jdeast
Copy link
Owner

jdeast commented Mar 25, 2024 via email

@rpoleski
Copy link
Collaborator

rpoleski commented Mar 25, 2024

I'm for stating that BJD_TDB should be provided by the user and if they don't, then they introduce small level errors. These errors are important for 1 out of 10,000 ground-based events. For Roman data, I agree we will get BJD_TDB for free.

I've checked mm.MulensData.__init__(). Scientifically important keywords are:

  • photometry format flux vs. mag,
  • ephemeris,
  • bandpass.

Above plus an additional detrending info, plotting info etc., for me suggests we should use some metadata rather than encode information in time stamps etc.

The disadvantage of providing fluxes instead of magnitudes are the limits on lens brightness and the properties of the source. Currently we use such constraints from a single dataset (the first one actually), but we could have it as a flag - use it for lens/source properties constraints or not. Such a flag once more suggests metadata.

The metadata could be passed at the top of the file, in a separate file (one per photometry file), or in the settings file (e.g., see these 2 lines).

We generally have not done de-trending so far.

@jenniferyee
Copy link
Collaborator Author

Ha! Here's an idea: We could write some tests!

@jenniferyee
Copy link
Collaborator Author

@jdeast
I propose you write a file of dates with columns for the different time systems: BJD_TDB, HJD, JD, etc. Span of 2 years.

Then, we can generate some trajectories using the different time systems and compare.

@jdeast
Copy link
Owner

jdeast commented Apr 1, 2024

Action item for @jdeast

Create file with 1 minute cadence for 2 years with 6 columns:
BJD_TDB, BJD_UTC, HJD_TDB, HJD_UTC, JD_TDB, JD_UTC,

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

No branches or pull requests

3 participants