TypeError: Cannot read property 'avatar_url' or null #4

mpconte · 2020-09-08T16:17:37Z

Hello,

I can't reproduce this all the time, but maybe every other time I get the following error:

TypeError: Cannot read property 'avatar_url' of null at Object.createMessageCard (C:\Users\rdbot\Desktop\action-runners\pdp_utils\_work\_actions\jdcargile\ms-teams-notification\v1.2\dist\index.js:2341:39) at C:\Users\rdbot\Desktop\action-runners\pdp_utils\_work\_actions\jdcargile\ms-teams-notification\v1.2\dist\index.js:2959:54 at Generator.next (<anonymous>) at fulfilled (C:\Users\rdbot\Desktop\action-runners\pdp_utils\_work\_actions\jdcargile\ms-teams-notification\v1.2\dist\index.js:2906:58) at processTicksAndRejections (internal/process/task_queues.js:93:5) ##[error]Cannot read property 'avatar_url' of null

The text was updated successfully, but these errors were encountered:

jdcargile · 2020-09-08T16:28:37Z

@mpconte, do you have a user that is making commits that doesn't have an avatar? I can test this myself, but curious whether you're seeing any consistency from the users who commit who are seeing this issue?

mpconte · 2020-09-08T16:30:34Z

Yes, I'm performing the commit and I don't have an avatar in Microsoft Teams and I think someone else makes commits too but does have one. Does an avatar have to be necessary?

jdcargile · 2020-09-09T02:35:32Z

Thanks! I will take a look at this before the end of the week.

jdcargile · 2020-09-09T05:41:46Z

@mpconte, this is referencing the author of the commit in GitHub. I can see that you have an avatar in GitHub. Do you have an automated task that is creating the commits for you when it fails?

mpconte · 2020-09-09T12:29:47Z

@jdcargile My gihub workflow using this action doesn't run on commits (sorry), I have it set as a workflow_dispatch to checkout changes, build and package it and notify microsoft teams at the end if the previous steps succeed.

vtrusevich-incomm · 2020-10-07T17:53:13Z

It looks like the issue is reproduced, when the last commit is made by the user, whose email is not registered in GitHub

vtrusevich-incomm · 2020-10-07T17:57:30Z

@jdcargile , I see, that the author is taken from commit here

ms-teams-notification/dist/index.js

Line 2958 in a94290d

const author = commit.data.author;

. Looks like it is needed to add some checks on author existence before building the card

dnepusb2 · 2020-12-16T17:01:11Z

Hey, I am running into the same issue....any good news?

tsposato · 2020-12-17T00:41:30Z

I'm also running into this issue, is there any progress on a fix?
Error is here:
TypeError: Cannot read property 'avatar_url' of null
at Object.createMessageCard (/home/runner/work/_actions/jdcargile/ms-teams-notification/v1.2/dist/index.js:2341:39)
at /home/runner/work/_actions/jdcargile/ms-teams-notification/v1.2/dist/index.js:2959:54
at Generator.next ()
at fulfilled (/home/runner/work/_actions/jdcargile/ms-teams-notification/v1.2/dist/index.js:2906:58)
at processTicksAndRejections (internal/process/task_queues.js:93:5)
Error: Cannot read property 'avatar_url' of null

jdcargile · 2020-12-17T15:33:10Z

Thank you all for your comments and questions. What would you suggest we use for the author if it is not found? Should I do a default avatar image or omit the image altogether?

dnepusb2 · 2020-12-17T15:39:21Z

He JD,
Thanks for the quick follow up. From my perspective:

Author undefined
Default avatar image

Cheers and thanks again!

tsposato · 2020-12-17T18:52:09Z

Sounds good to me.

jdcargile · 2020-12-18T03:22:41Z

This is fixed in #7. To pick up the new version, update your action version to use v1.3. See snippet below for more information.

uses: jdcargile/[email protected]

tsposato · 2020-12-18T06:13:12Z

I updated to 1.3 but I still received the same error.

jdcargile · 2020-12-18T06:22:44Z

I updated to 1.3 but I still received the same error.

@tsposato, can you try using uses: jdcargile/ms-teams-notification (don't provide the version so it grabs master)? If that works I will create another release. I just pushed what I think will fix this finally.

tsposato · 2020-12-18T06:43:16Z

@tsposato, can you try using uses: jdcargile/ms-teams-notification (don't provide the version so it grabs master)? If that works I will create another release. I just pushed what I think will fix this finally.

Will do. Not sure I'll get to test this until Monday as 5pm has rolled around but I'll let you know the outcome as soon as I can.

tsposato · 2020-12-18T06:52:47Z

The other weird thing is that the person in question does actually have an avatar set. Unless I'm misunderstanding the way it retrieves an avatar. Is there something strange about how GitHub does things avatar wise I'm not getting?

jdcargile · 2020-12-18T07:14:03Z

This might not be fixed then. Perhaps I need to query the user directly before trying to grab their information. I can look into this more tomorrow.

tsposato · 2020-12-21T01:05:37Z

Slightly different error when using master now @jdcargile :

TypeError: Cannot read property 'login' of null
at Object.createMessageCard (/home/runner/work/_actions/jdcargile/ms-teams-notification/master/dist/index.js:2461:85)
at /home/runner/work/_actions/jdcargile/ms-teams-notification/master/dist/index.js:3090:54
at Generator.next ()
at fulfilled (/home/runner/work/_actions/jdcargile/ms-teams-notification/master/dist/index.js:3044:58)
at processTicksAndRejections (internal/process/task_queues.js:93:5)
Error: Cannot read property 'login' of null

tsposato · 2020-12-21T04:36:38Z

Ok, so after some more digging it turns out the user had incorrectly spelt their email in their git user.email settings on one of their clients, hence why the user isn't being linked to their github account correctly. I think it should still probably be 'caught' instead of just failing completely though. Maybe just grab the name from the commit message and use that default avatar.

akshata-kenchanagudd · 2021-01-21T13:56:36Z

Hi @jdcargile,

Getting the below error when using "uses: jdcargile/ms-teams-notification" instead of uses: jdcargile/[email protected]. Kindly suggest.
The workflow is not valid. .github/workflows/terraform-validate.yml (Line: 182, Col: 17): Expected format {org}/{repo}[/path]@ref. Actual 'jdcargile/ms-teams-notification' Input string was not in a correct format.

stuartforrest-infinity · 2021-07-07T12:09:47Z

@jdcargile can you release a v1.4 that includes this commit - 3e536e0?

gspindev · 2021-07-08T09:54:50Z

@jdcargile facing same issue - using v1.3

TypeError: Cannot read property 'avatar_url' of null
at Object.createMessageCard (/home/runner/work/_actions/jdcargile/ms-teams-notification/v1.3/dist/index.js:2446:16)
at /home/runner/work/_actions/jdcargile/ms-teams-notification/v1.3/dist/index.js:3088:54
at Generator.next ()
at fulfilled (/home/runner/work/_actions/jdcargile/ms-teams-notification/v1.3/dist/index.js:3042:58)
at processTicksAndRejections (internal/process/task_queues.js:93:5)
Error: Cannot read property 'avatar_url' of null

rwetzeler · 2021-07-30T14:01:07Z

The other weird thing is that the person in question does actually have an avatar set. Unless I'm misunderstanding the way it retrieves an avatar. Is there something strange about how GitHub does things avatar wise I'm not getting?

We experienced this exact problem. When I dug in further, it appears that the author, was different than who committed... that author wasn't registered in GitHub from Name and email, but SSH keys are.. so he is a valid contributor on the repository, but GitHub doesn't recognize the email he committed with (because he didn't add that in his profile), yet his SSH key's re valid to commit.

I propose that if avatar_url fails, you put in a default avatar image, instead of failing the job.

825i · 2021-09-01T08:58:57Z

The other weird thing is that the person in question does actually have an avatar set. Unless I'm misunderstanding the way it retrieves an avatar. Is there something strange about how GitHub does things avatar wise I'm not getting?

We experienced this exact problem. When I dug in further, it appears that the author, was different than who committed... that author wasn't registered in GitHub from Name and email, but SSH keys are.. so he is a valid contributor on the repository, but GitHub doesn't recognize the email he committed with (because he didn't add that in his profile), yet his SSH key's re valid to commit.

I propose that if avatar_url fails, you put in a default avatar image, instead of failing the job.

Hi mate, have you got a pull request that shows how to fix this? Most of our users do not have avatars.

mariam-alexander · 2021-11-17T10:57:47Z

Is there a fix for this issue yet ?

lumos94 · 2021-12-07T15:22:19Z

same here, started having this issue since yesterday! all was good until suddenly it stopped!
the weird thing is that this happens only to 1 of my projects. in the other projects it works fine!

dennisgroisman · 2022-01-12T20:01:49Z

Having this issue since last week. Looks like 3e536e0 fixes it
@jdcargile ?

EvgeniyRub · 2022-02-16T09:13:46Z

anibody fixed this issue already?

bfernandes-d · 2022-05-27T10:45:31Z

Any news on this bug ?

dimitar-cp · 2022-06-15T10:16:26Z

This started appearing today. Any news on the fix?

LeonSnajdr · 2022-07-14T09:49:45Z

I looked at the forks and searched for a fix, one fixed the bug in this pre-release https://github.com/TBCTSystems/ms-teams-notification/releases/tag/v1.3.1

LeonSnajdr · 2022-07-14T09:52:54Z

Maybe someone can create a pull request if it works for you too.

silveiratalita · 2022-07-14T18:47:06Z

try this, for me it works! Only this, and remove other parameters.

name: "Microsoft Teams - Notification"
uses: toko-bifrost/ms-teams-deploy-card@master
if: always()
with:
github-token: ${{ github.token }}
webhook-uri: ${{ secrets.YOUR_TEAMS_WEBHOOK }}
timezone: America/Sao_Paulo

elubikowski · 2022-11-04T12:48:46Z

You have to have git user configured globally. I was using custom configuration without global settings. Adding as follows fixed the issue.
Obviously provide your values between double-quotes ;)

git config --global user.name "your_username"
git config --global user.email "[email protected]"

gfrid · 2023-01-31T11:47:55Z

this is still not fixed in 1.3 getting the same error, i think the owner of code does not continue to support this code
i will move to another one

TypeError: Cannot read property 'avatar_url' of null
at Object.createMessageCard (/runner/_work/_actions/jdcargile/ms-teams-notification/v1.3/dist/index.js:2446:16)
at /runner/_work/_actions/jdcargile/ms-teams-notification/v1.3/dist/index.js:3088:54
at Generator.next ()
at fulfilled (/runner/_work/_actions/jdcargile/ms-teams-notification/v1.3/dist/index.js:3042:58)
at processTicksAndRejections (internal/process/task_queues.js:97:5)
Error: Cannot read property 'avatar_url' of null

bkagan98 · 2024-03-01T19:13:46Z

Was this avatar_url issue ever fixed? We're still getting this error with v1.3...

kimbalabhay · 2024-05-02T06:24:12Z

Was this avatar_url issue ever fixed? We're still getting this error with v1.3...

same here

nmacri · 2024-11-04T23:04:40Z

@bkagan98 @kimbalabhay Confirming that we are seeing the avatar_url issue fixed on v1.4

jdcargile added the bug Something isn't working label Sep 8, 2020

jdcargile self-assigned this Sep 8, 2020

agentschmitt mentioned this issue Nov 7, 2022

fix empty author dragos-cojocari/ms-teams-notification#2

Merged

ArthurNRL mentioned this issue Apr 26, 2023

Cannot read properties of null (reading 'login') mikesprague/teams-incoming-webhook-action#143

Closed

TypeError: Cannot read property 'avatar_url' or null #4

TypeError: Cannot read property 'avatar_url' or null #4

Comments

mpconte commented Sep 8, 2020

jdcargile commented Sep 8, 2020

mpconte commented Sep 8, 2020 • edited Loading

jdcargile commented Sep 9, 2020

jdcargile commented Sep 9, 2020

mpconte commented Sep 9, 2020 • edited Loading

vtrusevich-incomm commented Oct 7, 2020 • edited Loading

vtrusevich-incomm commented Oct 7, 2020

dnepusb2 commented Dec 16, 2020

tsposato commented Dec 17, 2020 • edited Loading

jdcargile commented Dec 17, 2020

dnepusb2 commented Dec 17, 2020

tsposato commented Dec 17, 2020

jdcargile commented Dec 18, 2020

tsposato commented Dec 18, 2020

jdcargile commented Dec 18, 2020 • edited Loading

tsposato commented Dec 18, 2020 • edited Loading

tsposato commented Dec 18, 2020

jdcargile commented Dec 18, 2020

tsposato commented Dec 21, 2020

tsposato commented Dec 21, 2020

akshata-kenchanagudd commented Jan 21, 2021

stuartforrest-infinity commented Jul 7, 2021

gspindev commented Jul 8, 2021

rwetzeler commented Jul 30, 2021

825i commented Sep 1, 2021

mariam-alexander commented Nov 17, 2021

lumos94 commented Dec 7, 2021 • edited Loading

dennisgroisman commented Jan 12, 2022 • edited Loading

EvgeniyRub commented Feb 16, 2022

bfernandes-d commented May 27, 2022

dimitar-cp commented Jun 15, 2022

LeonSnajdr commented Jul 14, 2022 • edited Loading

LeonSnajdr commented Jul 14, 2022

silveiratalita commented Jul 14, 2022 • edited Loading

elubikowski commented Nov 4, 2022

gfrid commented Jan 31, 2023 • edited Loading

bkagan98 commented Mar 1, 2024 • edited Loading

kimbalabhay commented May 2, 2024

nmacri commented Nov 4, 2024

mpconte commented Sep 8, 2020 •

edited

Loading

mpconte commented Sep 9, 2020 •

edited

Loading

vtrusevich-incomm commented Oct 7, 2020 •

edited

Loading

tsposato commented Dec 17, 2020 •

edited

Loading

jdcargile commented Dec 18, 2020 •

edited

Loading

tsposato commented Dec 18, 2020 •

edited

Loading

lumos94 commented Dec 7, 2021 •

edited

Loading

dennisgroisman commented Jan 12, 2022 •

edited

Loading

LeonSnajdr commented Jul 14, 2022 •

edited

Loading

silveiratalita commented Jul 14, 2022 •

edited

Loading

gfrid commented Jan 31, 2023 •

edited

Loading

bkagan98 commented Mar 1, 2024 •

edited

Loading