Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Verbose Logging Control #35

Open
vbyrd opened this issue May 2, 2022 · 1 comment
Open

Verbose Logging Control #35

vbyrd opened this issue May 2, 2022 · 1 comment

Comments

@vbyrd
Copy link
Contributor

vbyrd commented May 2, 2022

Problem: This action emits a large amount of logging by default. When used in a composite action with other steps, this action will eclipse the logs of other steps.

Example:
image

Solution: I created a PR to add Verbose Logging control via an optional "verbose-logging" input:
#34

I have not tested these changes.

@AlexanderPodlesniyQs
Copy link

Looks like verbose-logging parameter is not working.
I see in workflow log that verbose-logging: false (I didn't specified it explicitly in action parameters) but additional log data is also in the log.
I also tried to set it to false in action parameters, but it doesn't work either.

Probably, this condition is not correct:

const verboseLogging = core.getInput('verbose-logging') == 'true'

As I see current code differs from #34 PR changes, but this issue is still opened

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

No branches or pull requests

2 participants