Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Can we use a different package name for v2? #49

Open
lmeadors opened this issue Mar 10, 2023 · 4 comments
Open

Can we use a different package name for v2? #49

lmeadors opened this issue Mar 10, 2023 · 4 comments

Comments

@lmeadors
Copy link

Would it be possible to use a different package name for v2?

As I understand it, the FQCN class name identifies the plugin to be used.

If the v1 and v2 names are the same, we will not be able to use both while migrating.

For those of us without unlimited clusters, that's not awesome.

@jcustenborder
Copy link
Owner

@lmeadors Hmmm I haven't thought about that. The goal was for v2 to be backwards compatible with v1.

@lmeadors
Copy link
Author

lmeadors commented Mar 10, 2023

I am trying a snapshot of v2 today in our development environment, but am a bit worried I will hose other things. Running them side-by-side would be less risky, even if they were compatible enough to just change the class name to move from v1 to v2 eventually.

...but I think I see another potential issue: If we move this to a "v2" package, that would make merging back to master messy.

I may have just talked myself out of this idea. ¯\(ツ)

Unless you want to think on it or discuss this more, feel free to close the issue; thanks for the clarification.

@lmeadors
Copy link
Author

lmeadors commented Mar 20, 2023

@jcustenborder - I was thinking about this more.

Would a temporary "V2" suffix of the connector class names allow both to be deployed together? If so, that might solve both problems.

People (like me) could use both V1 and V2 together because the class lookups would be unique, then after a reasonable compatibility testing period, the suffix could be dropped.

Dropping that suffix might cause a bit of a disruption when upgrading to the V2 release, but only for people using both side-by-side.

For people only using one or the other (assuming the compatibility works well), no one would have to know.

PS: Please note the emphasis on "temporary" there, and if you are OK with this, I would be happy to send a PR your way with that refactoring.

@jcustenborder
Copy link
Owner

Well my goal was to keep the original class name and make it backwards compatible. I was going to log a warning telling you to move.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

No branches or pull requests

2 participants