Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

[Regression] You can't return jQuery Terminal instance from interpreter anymore #994

Open
jcubic opened this issue Dec 15, 2024 · 0 comments

Comments

@jcubic
Copy link
Owner

jcubic commented Dec 15, 2024

Issue summary

You should be able to return JQuery Terminal instance from the interpreter

Expected behavior

The return value should be ignored

Steps to reproduce

Browser and OS

Additional notes

I think that this was working. So you can have code that early return:

$('body').terminal({
  test(x = null) {
    if (!x) {
      return this.error('x is required');
    }
    this.echo(x);
  }
}, {
  checkArity: false
});

This regression probably happened when echo started accepting jQuery objects.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
Development

No branches or pull requests

1 participant