Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Nested interpreters should have exit command by default #988

Open
jcubic opened this issue Dec 8, 2024 · 1 comment
Open

Nested interpreters should have exit command by default #988

jcubic opened this issue Dec 8, 2024 · 1 comment
Labels

Comments

@jcubic
Copy link
Owner

jcubic commented Dec 8, 2024

I have an idea for a new feature for jQuery Terminal

Just notices that exit command was not defined when using terminal::push()

this is the code responsible for setting exit:

exit: !!(options && options.login || !options)

exit should always be defined for nested interpreters unless exit is explicitly set to false.

We can also add exit option to push().

@jcubic jcubic added the feature label Dec 8, 2024
@jcubic
Copy link
Owner Author

jcubic commented Dec 8, 2024

Maybe it will be good idea to keep top level exit only when login is used. But for nested interpreters it should be defined.

Maybe even remove this error message

canExitError: "You can't exit from main interpreter",

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
Projects
None yet
Development

No branches or pull requests

1 participant