Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Remove dependency on Spring and Groovy #11

Open
jean-morissette opened this issue Jan 6, 2017 · 1 comment
Open

Remove dependency on Spring and Groovy #11

jean-morissette opened this issue Jan 6, 2017 · 1 comment

Comments

@jean-morissette
Copy link

jean-morissette commented Jan 6, 2017

First, congratulations for your project and thanks for your open source contribution!

We have rewritten your test cases in pure Java - just keeping junit dependency - to help us track some corner issues. Please let me know if you are interested by a pull request. Maybe it could help the project since Groovy can be scary for some developpers and not everyone want to add Spring to their stack.

@manuel-mauky
Copy link
Contributor

The spring dependency is only for tests, isn't it?. Developers don't need to "add Spring to their stack" if they only use the library.

For me the groovy tests were a little scary too but not so much that they would have discouraged me from contributing. However, I would feel more familiar with JUnit too.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

No branches or pull requests

2 participants