Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

vpl_evaluate.cpp file in compilation environment #179

Open
Astor-Bizard opened this issue Mar 6, 2024 · 2 comments
Open

vpl_evaluate.cpp file in compilation environment #179

Astor-Bizard opened this issue Mar 6, 2024 · 2 comments
Assignees
Labels

Comments

@Astor-Bizard
Copy link
Contributor

Hello!

It has come to my attention that the vpl_evaluate.cpp file is now present in the compilation environment.
We can see it by having a vpl_evaluate.sh file containing simply ls:

common_script.sh  vpl_debug.sh	      vpl_evaluate.cases  vpl_evaluate.sh
myreqfile.py      vpl_environment.sh  vpl_evaluate.cpp	  vpl_run.sh

It seems that this is new from version 4.2. In previous versions, the file was not present among the others.

This change came with what seems to be the following behaviour: any VPL activity with a manually-created vpl_evaluate.cpp file in Execution files will have this file removed and replaced by the "automatic" vpl_evaluate.cpp.

Now, my questions are:
Are these changes intentional?
If not, should we expect it to be reverted?

@buddy1234567
Copy link

Good sleuthing! I wonder if this also pertains to the Proposed Grade issue in #178.

@jcrodriguez-dis jcrodriguez-dis self-assigned this Mar 7, 2024
@jcrodriguez-dis
Copy link
Owner

Dear @Astor-Bizard and @buddy1234567,

Thank you for bringing this issue to our attention.

To clarify, the replacement of a custom vpl_evaluate.cpp file with the default version is not an intentional feature or a change in our approach. It is, unfortunately, a bug. Our design philosophy is that custom configurations should always have precedence over default settings.

The presense of the default vpl_evaluate.cpp file if no custom version is provided allows users the flexibility to write custom vpl_evaluate.sh scripts that may leverage the default vpl_evaluate.cpp program, for example creating dinamic test cases files. However, it's important to note that before the execution phase, the vpl_evaluate.cpp file is removed.

Given the significance of this bug and its impact on user experience, we recognize the urgency of issuing a fix.

We apologize for the inconvenience this has caused and appreciate your patience and understanding as we work to rectify this issue.

Best regards,
Juan Carlos

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
Projects
None yet
Development

No branches or pull requests

3 participants