Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Don't send nil Arguments or ArgumentsKw #72

Open
jcelliott opened this issue Feb 4, 2015 · 2 comments
Open

Don't send nil Arguments or ArgumentsKw #72

jcelliott opened this issue Feb 4, 2015 · 2 comments
Assignees
@jcelliott
Labels
bug

Comments

@jcelliott
Copy link
Owner

https://github.com/tavendo/WAMP/blob/master/spec/basic.md#call-1
https://github.com/tavendo/WAMP/blob/master/spec/basic.md#empty-arguments-and-keyword-arguments

Specifically in RESULT messages, but we should check INVOCATION and possibly others.
@jcelliott jcelliott added the bug label Feb 4, 2015
@jcelliott jcelliott self-assigned this Feb 4, 2015
jcelliott referenced this issue Feb 4, 2015
@beatgammit
Removed "constructors" for CallResult and made members public
aac3b18 
- the constructors really weren't that much nicer than just using the
  struct; they can be added again later if it turns out it's overly
  tedious
- also "fixed" Yield to not allow multiple yields for a single call
  - will need some work to support the advanced profile, but this
    implementation wasn't correct either and had a memory leak
@beatgammit
Copy link
Collaborator

#9 would hopefully prevent things like this from happening in the future, but I don't know if the current test framework actually tests WAMP or if it just tests WebSockets.

If such a thing doesn't exist, perhaps we should create one?

@jcelliott
Copy link
Owner Author

@beatgammit said:

Fixing this in the serializer is probably the best place to do it, since that prevents null from ever accidentally making it in.

We can also add a simple check in a few places like this

@beatgammit beatgammit mentioned this issue Mar 30, 2015
Merged
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Assignees

@jcelliott jcelliott

Labels
bug
Projects
None yet
Milestone
No milestone
Development

No branches or pull requests
2 participants
@beatgammit @jcelliott