Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Cannot configure HttpClient via HttpClientBuilder #211

Open
GoogleCodeExporter opened this issue Jun 4, 2015 · 2 comments
Open

Cannot configure HttpClient via HttpClientBuilder #211

GoogleCodeExporter opened this issue Jun 4, 2015 · 2 comments
Labels
auto-migrated Priority-Medium Type-Defect

Comments

@GoogleCodeExporter
Copy link 

What steps will reproduce the problem?
1. Try to configure HttpClient via HttpClientBuilder.
2. Fail because openid4java uses its own HttpClientFactory instead, which calls 
the DefaultHttpClient constructor.

What is expected?
openid4java uses an injectable HttpClientBuilder to construct its HttpClient.

What version of the product are you using? On what operating system?
0.9.8

Please provide any additional information below.
DefaultHttpClient is deprecated and shouldn't be used directly.

Original issue reported on code.google.com by [email protected] on 17 Jun 2014 at 8:14
@cryptomilk
Copy link

This is reason why SNI support with OpenID in Gerrit doesn't work.

https://bugs.chromium.org/p/gerrit/issues/detail?id=5047

@jukedom
Copy link

jukedom commented Jun 6, 2018

@cryptomilk exactly, there is an existing fork that supports SNI : #219.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Assignees
No one assigned
Labels
auto-migrated Priority-Medium Type-Defect
Projects
None yet
Milestone
No milestone
Development

No branches or pull requests
3 participants
@cryptomilk @GoogleCodeExporter @jukedom