Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

add concurrent support for removeDeletedNodes #274

Closed
jbellis opened this issue Apr 11, 2024 · 1 comment
Closed

add concurrent support for removeDeletedNodes #274

jbellis opened this issue Apr 11, 2024 · 1 comment

Comments

@jbellis
Copy link
Owner

jbellis commented Apr 11, 2024

This is important to allow larger indexes to support deletes without pausing updates and searches.

Unfortunately my first attempt at solving this didn't work out and was removed in #273.

The problem is that the logical clock used to detect when searches were done does not work when GraphSearchers are pooled and reused (which we want to allow to reduce allocation churn).

I think the solution is as simple as just creating a new View per search (the Views are much more lightweight than the Searchers), but otoh it's a bit of a shame to churn all Views when it's only the on-heap one that is a problem.

@jbellis
Copy link
Owner Author

jbellis commented Apr 11, 2024

closing in favor of #272

@jbellis jbellis closed this as completed Apr 11, 2024
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

No branches or pull requests

1 participant