Skip to content
This repository has been archived by the owner on Mar 20, 2021. It is now read-only.

OWASP character escape recomendation that could be applied for HTMLUtils.java #4251

Open
josedefreitasc opened this issue May 31, 2017 · 2 comments

Comments

@josedefreitasc
Copy link

Hi,

I was wondering if some security recommendations given by the OWASP could be included in jsf-impl, currently we are making some improvement over the security but we would like to avoid to make changes over the standard version. In this case, the OWASP recommend to escape the characters &, <, >, ", ', / until now the characters that are escaped in the HTMLUtils.java (package com.sun.faces.util) are <,>,&,” without including the single quote and the forward slash. Could this two character be included in the escaped characters for the standard?

Here I share the recommendation from the OWASP: OWASP recomendation

Thanks,
José

@BalusC
Copy link
Collaborator

BalusC commented Sep 23, 2017

Technically, escaping apostrophe is not necessary as JSF HTML renderer never renders the apostrophe as attribute value separator and escaping forward slash is not necessary as JSF HTML renderer never renders partial entities.

@edburns
Copy link
Member

edburns commented Oct 29, 2017

Please see this important message regarding community contributions to
Mojarra.

https://javaee.groups.io/g/jsf-spec/message/30

Also, please consider joining that group, as that group has taken the
place of the old [email protected] mailing list.

Thanks,

Ed Burns

Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.
Projects
None yet
Development

No branches or pull requests

3 participants