Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Update dependency for better compatibility with Windows #7

Open
egfx-notifications opened this issue Jan 27, 2021 · 2 comments
Open

Comments

@egfx-notifications
Copy link

The codeowners npm package had a problem when the CODEOWNERS file didn't use \n as linebreak character. In the case of Windows (\r\n) this resulted in an additional, empty username entry for code owners.

I made a PR for the library which just got released in version 4.2.1. It would be great if you could make a new release of your extension available for the marketplace, so it properly works on Windows.

@jasonnutter
Copy link
Owner

@egfx-notifications Thanks for the heads up, I'll make sure that gets updated.

@repi
Copy link

repi commented Jan 12, 2022

Seeing this problem with the extension also, and it also makes the status bar a bit confused showing "CODEOWNERS: @user & 1 other") even though there is no other user, just an empty user name.

Possible to do an update?

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

No branches or pull requests

3 participants