-
Notifications
You must be signed in to change notification settings - Fork 10
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Startup warning on server #16
Comments
If it doesn't crash, then what is the issue? Just asking, I am not implying that there is no issue, I simply do not understand and am curious. |
@DragonEggBedrockBreaking It appears it is complaining that createNetherGenerator(method_28535) is set to private in MixinDimensionType.java when the target method in the game is public. It is warning that it is making the method in that file public even though it was set to private. |
So that's what you fixed on your fork? Are you going to pull request it? |
@DragonEggBedrockBreaking Yes I have fixed it but I am testing it so see if the warning has gone away, but I can't even find that warning while the method is set to private in a dev environment. I also don't see that method as being public in the game's code. I am going to do some testing before making a pr to see if it is an issue. |
@srnyx can you send more information about your server, like what game version is it running and the version of the mod? I can not reproduce this issue with a 1.16.5 server with a build of the latest version. |
I cannot reproduce in 1.16.5 singleplayer |
The server is running Fabric 1.16.5 and the mod version is 1.0.4 |
Where did you get the release? Was it from CurseForge? Did you build yourself? |
@srnyx Can you build and test my fork to see if it fixes the error? https://github.com/EcoBuilder13/overworld-two |
CurseForge |
Alright, how do I build it? |
@srnyx Go to my fork(link above), then click the green code button then download zip. Once it has downloaded unzip/extract the folder. Go into the folder and copy the file path. Then open the command prompt and type |
It says
|
You need to install a JDK. Download from here (use jdk 8 or 11 (16 has issues with gradle rn) and hotspot): https://adoptopenjdk.net/ Download the installer, double click on it and follow the instructions. |
Still getting the same error |
@srnyx I can send you a build of the mod if you join the discord server. Just head to #overworld-two and ping me. |
Run GitHub Actions on your fork, and they can grab a build from there. |
[13:49:55] [main/WARN]: Static binding violation: PRIVATE @overwrite method method_28535 in overworld_two.mixins.json:MixinDimensionType cannot reduce visibiliy of PUBLIC target method, visibility will be upgraded.
The text was updated successfully, but these errors were encountered: