Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Startup warning on server #16

Open
srnyx opened this issue Mar 20, 2021 · 17 comments
Open

Startup warning on server #16

srnyx opened this issue Mar 20, 2021 · 17 comments

Comments

@srnyx
Copy link

srnyx commented Mar 20, 2021

[13:49:55] [main/WARN]: Static binding violation: PRIVATE @overwrite method method_28535 in overworld_two.mixins.json:MixinDimensionType cannot reduce visibiliy of PUBLIC target method, visibility will be upgraded.

@DragonEggBedrockBreaking
Copy link
Contributor

If it doesn't crash, then what is the issue? Just asking, I am not implying that there is no issue, I simply do not understand and am curious.

@EcoBuilder13
Copy link

@DragonEggBedrockBreaking It appears it is complaining that createNetherGenerator(method_28535) is set to private in MixinDimensionType.java when the target method in the game is public. It is warning that it is making the method in that file public even though it was set to private.

@DragonEggBedrockBreaking
Copy link
Contributor

@DragonEggBedrockBreaking It appears it is complaining that createNetherGenerator(method_28535) is set to private in MixinDimensionType.java when the target method in the game is public. It is warning that it is making the method in that file public even though it was set to private.

So that's what you fixed on your fork? Are you going to pull request it?

@EcoBuilder13
Copy link

@DragonEggBedrockBreaking Yes I have fixed it but I am testing it so see if the warning has gone away, but I can't even find that warning while the method is set to private in a dev environment. I also don't see that method as being public in the game's code. I am going to do some testing before making a pr to see if it is an issue.

@EcoBuilder13
Copy link

@srnyx can you send more information about your server, like what game version is it running and the version of the mod? I can not reproduce this issue with a 1.16.5 server with a build of the latest version.

@DragonEggBedrockBreaking
Copy link
Contributor

I cannot reproduce in 1.16.5 singleplayer

@srnyx
Copy link
Author

srnyx commented Mar 21, 2021

@srnyx can you send more information about your server, like what game version is it running and the version of the mod? I can not reproduce this issue with a 1.16.5 server with a build of the latest version.

The server is running Fabric 1.16.5 and the mod version is 1.0.4
Here's a list of all my mods (lots of them are just libraries): https://pastebin.com/SCeuY0mc
Here's the mods in the server folder, it may be like tiny bit outdated though: https://imgur.com/a/1rCPvsl

@DragonEggBedrockBreaking
Copy link
Contributor

The server is running Fabric 1.16.5 and the mod version is 1.0.4

Where did you get the release? Was it from CurseForge? Did you build yourself?

@EcoBuilder13
Copy link

@srnyx Can you build and test my fork to see if it fixes the error? https://github.com/EcoBuilder13/overworld-two

@srnyx
Copy link
Author

srnyx commented Mar 21, 2021

The server is running Fabric 1.16.5 and the mod version is 1.0.4

Where did you get the release? Was it from CurseForge? Did you build yourself?

CurseForge

@srnyx
Copy link
Author

srnyx commented Mar 21, 2021

@srnyx Can you build and test my fork to see if it fixes the error? https://github.com/EcoBuilder13/overworld-two

Alright, how do I build it?
I've never really found a clear way on how to build things on GitHub.

@EcoBuilder13
Copy link

@srnyx Go to my fork(link above), then click the green code button then download zip. Once it has downloaded unzip/extract the folder. Go into the folder and copy the file path. Then open the command prompt and type cd FILEPATH (replace filepath with the path you copied). If it works you should see that you are in that folder at the beginning of the prompt. Once you are there enter ./gradlew build, wait for it to say build successful then go back to your file explorer and go into the build folder then libs and copy the jar file that does not have dev or sources in the name. Replace the old jar with that jar and see if it causes the error.

@srnyx
Copy link
Author

srnyx commented Mar 21, 2021

@srnyx Go to my fork(link above), then click the green code button then download zip. Once it has downloaded unzip/extract the folder. Go into the folder and copy the file path. Then open the command prompt and type cd FILEPATH (replace filepath with the path you copied). If it works you should see that you are in that folder at the beginning of the prompt. Once you are there enter ./gradlew build, wait for it to say build successful then go back to your file explorer and go into the build folder then libs and copy the jar file that does not have dev or sources in the name. Replace the old jar with that jar and see if it causes the error.

It says '.' is not recognized as an internal or external command, operable program or batch file.
So I removed the . and / and just did gradlew build, it then said build failed

* What went wrong:
Execution failed for task ':compileJava'.
> Could not find tools.jar. Please check that C:\Program Files (x86)\Java\jre1.8.0_261 contains a valid JDK installation.

@DragonEggBedrockBreaking
Copy link
Contributor

it then said build failed

You need to install a JDK. Download from here (use jdk 8 or 11 (16 has issues with gradle rn) and hotspot): https://adoptopenjdk.net/

Download the installer, double click on it and follow the instructions.

@srnyx
Copy link
Author

srnyx commented Mar 21, 2021

it then said build failed

You need to install a JDK. Download from here (use jdk 8 or 11 (16 has issues with gradle rn) and hotspot): https://adoptopenjdk.net/

Download the installer, double click on it and follow the instructions.

Still getting the same error

@EcoBuilder13
Copy link

@srnyx I can send you a build of the mod if you join the discord server. Just head to #overworld-two and ping me.

@DragonEggBedrockBreaking
Copy link
Contributor

@srnyx I can send you a build of the mod if you join the discord server. Just head to #overworld-two and ping me.

Run GitHub Actions on your fork, and they can grab a build from there.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

No branches or pull requests

3 participants