Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

fix/help: test command no longer runs Jest in watch mode #734

Merged
merged 1 commit into from
Jul 12, 2020
Merged

fix/help: test command no longer runs Jest in watch mode #734

merged 1 commit into from
Jul 12, 2020

Conversation

bmihelac
Copy link
Contributor

@bmihelac bmihelac commented May 25, 2020 •
edited by agilgur5
Loading

ref: a2e4b78, follow-up to #536

@bmihelac bmihelac marked this pull request as draft May 27, 2020 15:04
@bmihelac bmihelac marked this pull request as ready for review May 27, 2020 15:04
@agilgur5 agilgur5 changed the title fix: test command does not run Jest in watch mode fix/help: test command does not run Jest in watch mode Jul 12, 2020
@agilgur5
Copy link
Collaborator

Like #536 this predates the CI=true addition & removal. But according to the blame, 3f3df68 was when this was originally added, and looking there it looks like an older version of TSDX also had the CI=true behavior 🤔

@agilgur5 agilgur5 changed the title fix/help: test command does not run Jest in watch mode fix/help: test command no longer runs Jest in watch mode Jul 12, 2020
@agilgur5 agilgur5 merged commit 8b148ce into jaredpalmer:master Jul 12, 2020
@agilgur5

This comment has been minimized.

Sign in to view
1 similar comment
@agilgur5

This comment has been minimized.

Sign in to view
@agilgur5
Copy link
Collaborator

agilgur5 commented Jul 14, 2020 •
edited
Loading

let's try that again... @all-contributors please add @bmihelac for code

EDIT: looks like this broke due to the org changes... I don't have permissions to re-enable this 😕

@agilgur5
Copy link
Collaborator

@allcontributors please add @bmihelac for code

Sorry for the spam!! The integration seems to have been fixed now after I made a request to the org and added #772

@allcontributors allcontributors bot mentioned this pull request Jul 19, 2020
Merged
@allcontributors
Copy link
Contributor

@agilgur5

I've put up a pull request to add @bmihelac! 🎉

@agilgur5 agilgur5 mentioned this pull request Jul 19, 2020
Merged
@agilgur5 agilgur5 mentioned this pull request Aug 11, 2020
Merged
paul-vd pushed a commit to EezyQuote/tsdx that referenced this pull request Dec 1, 2020
@bmihelac @paul-vd
fix/help: test command no longer runs Jest in watch mode (jaredpalmer…
9392e10 
…#734)

- test command was changed to not run in watch mode, but help dialog was missed
  - this fixes/updates the help dialog to the current state of the command

similar change ref: jaredpalmer@a2e4b78
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@agilgur5 agilgur5 agilgur5 approved these changes

Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
v0.13.x - Template Improvements & More
Development

Successfully merging this pull request may close these issues.
2 participants
@bmihelac @agilgur5