Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Use tsconfig "base" with overrides when neccessary? #901

Closed
ArturBaybulatov opened this issue Oct 11, 2020 · 1 comment
Closed

Use tsconfig "base" with overrides when neccessary? #901

ArturBaybulatov opened this issue Oct 11, 2020 · 1 comment
Labels
problem: removed issue template OP removed the issue template without good cause problem: stale Issue has not been responded to in some time scope: templates Related to an init template, not necessarily to core (but could influence core) solution: duplicate This issue or pull request already exists

Comments

@ArturBaybulatov
Copy link

https://www.typescriptlang.org/docs/handbook/tsconfig-json.html#tsconfig-bases

@agilgur5 agilgur5 added problem: removed issue template OP removed the issue template without good cause solution: duplicate This issue or pull request already exists labels Oct 12, 2020
@agilgur5
Copy link
Collaborator

agilgur5 commented Oct 12, 2020

Please don't remove the issue template, it is there for a reason.

This sounds like a duplicate of #634 / #753 . Given the removal of the template and lack of details, it is difficult to interpret if you meant use an existing base, e.g. @tsconfig/recommended or for TSDX to have its own base, i.e. @tsdx/tsconfig. Per the duplicated issues, I plan to have @tsdx/tsconfig that all the templates will extend. It will itself extend @tsconfig/recommended.
@tsconfig/recommended is itself only a few settings and isn't currently commented well, so I don't think changing to that in isolation (without @tsdx/tsconfig) is worthwhile. I actually wrote the code for that but decided against it and to wait until @tsdx/tsconfig exists, especially as that will make for a more intuitive dependency structure.

@agilgur5 agilgur5 changed the title Use "base" tsconfig with overrides when neccessary? Use tsconfig "base" with overrides when neccessary? Oct 12, 2020
@agilgur5 agilgur5 added the scope: templates Related to an init template, not necessarily to core (but could influence core) label Oct 12, 2020
@agilgur5 agilgur5 added the problem: stale Issue has not been responded to in some time label Oct 22, 2020
@agilgur5 agilgur5 added this to the Future Non-breaking milestone Oct 22, 2020
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
problem: removed issue template OP removed the issue template without good cause problem: stale Issue has not been responded to in some time scope: templates Related to an init template, not necessarily to core (but could influence core) solution: duplicate This issue or pull request already exists
Projects
None yet
Development

No branches or pull requests

2 participants