Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Add Kodiak bot for PRs? #891

Closed
jaredpalmer opened this issue Sep 29, 2020 · 3 comments
Closed

Add Kodiak bot for PRs? #891

jaredpalmer opened this issue Sep 29, 2020 · 3 comments
Labels
scope: internal Changes only affect the internal API

Comments

@jaredpalmer
Copy link
Owner

Been using https://kodiakhq.com on Formik and it really helps. I think it would help out a lot as you can approve a PR and it will automerge it once checks have finished and update other PRs as well. It's really really useful.

@agilgur5 Let me know if you want me to set it up. It requires protecting master and making certain tests required. If you want to see the impact checkout https://github.com/vercel/next.js, https://github.com/formium/formik, or this https://github.com/jaredpalmer/tsdx-monorepo I put together.

@agilgur5
Copy link
Collaborator

agilgur5 commented Sep 30, 2020

Thanks for the recommendation. Updating PRs is potentially useful a la Bors, but auto-merging would not be because I do a rebase merge or a squash merge pending the PR (if it is organized as independent commits or not), and with squash merges and contributor PRs, I am often re-writing the description since the PR/commit descriptions do not tend to be detailed and/or change over the lifetime of the PR. So unfortunately, that doesn't fit the workflow.

It looks like it may also add a comment, which I'm not a fan of -- I've gotten ~200+ unnecessary notifications from the Vercel bot (the vast majority of which don't even touch the website), which is extremely annoying and frustrating to me and some other contributors.

@agilgur5 agilgur5 changed the title (internal) Add Kodiak Add Kodiak bot for PRs? Sep 30, 2020
@agilgur5 agilgur5 added the scope: internal Changes only affect the internal API label Sep 30, 2020
@agilgur5
Copy link
Collaborator

It requires protecting master and making certain tests required

I would quite like to have branch protection set-up and make tests required in any case, as I've mentioned in #702 (comment) . If you could set that up or make me a member such that I can do that myself, that would be helpful.
I'd have to leave admin override on for reviewer rule though since no one is available to review my PRs.

@jaredpalmer
Copy link
Owner Author

@agilgur5 you’re now an admin, you should be able to invite other contributors now

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
scope: internal Changes only affect the internal API
Projects
None yet
Development

No branches or pull requests

2 participants