Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

[WIP] Support React Refresh #1069

Draft
wants to merge 73 commits into
base: master
Choose a base branch
from
Draft

[WIP] Support React Refresh #1069

wants to merge 73 commits into from

Conversation

japgolly
Copy link
Owner

@japgolly japgolly commented Jun 1, 2022 •
edited
Loading

Closes #1061

@japgolly japgolly force-pushed the topic/refreshReact branch from ef31959 to 39ce3dc Compare June 6, 2022 08:18
@japgolly
Copy link
Owner Author

Reminder: Try again to reproduce the Scala 3 lazy val bug now that I fiiiiiiiiiiiiiiiiiiiiiiiiiiiiiiiiiiinally know it's related to betaReduction

@japgolly
Copy link
Owner Author

japgolly commented Jun 20, 2022 •
edited
Loading

Create a Scala.js issue to elide those useless props.a; statements

Edit: Done. Raised scala-js/scala-js#4692

japgolly added 17 commits June 21, 2022 14:53
@japgolly
Got useCallback working
63a2045
@japgolly
Rename last context object to render_ctx
8298460
@japgolly
Support useCallbackWithDeps*
55723b7
@japgolly
useMemo* done
6d66364
@japgolly
use{Context,DebugValue,Reducer} done
142f6e1
@japgolly
Avoid shadowing in Scala 2
2fb130a
@japgolly
Consolidate some RR tests; test time is starting to get annoying
e868482
@japgolly
use*Effect*
5c17b04
@japgolly
useForceUpdate take 2
63c5df6
@japgolly
Support useRef*
a8693f4
@japgolly
Remove obsolete emission test output
df81d84
@japgolly
Upgrade Scala.js and re-gen all emissions
17f5b09
@japgolly
Support render with reuse with children
fc559e0
@japgolly
Fix Scala 2 compilation - stategy is fine
c4cf1b3 
Only polymorphic contexts need help, otherwise type inferance works fine
(as confirmed in tests)
@japgolly
Re-generate all test emissions with Scala.js 1.10.1
ebfd757
@japgolly
Add placeholder implementations for renderRR with reuse
ad7b116
@japgolly
Support RR in render{Reusable,WithReuse,WithReuseBy}
3a428e3
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers
No reviews
Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.

Support react-refresh for faster dev experience
1 participant
@japgolly