Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Interface & impl for filters to provide list of files that invalidate the cache #80

Open
fprochazka opened this issue Oct 12, 2014 · 8 comments

Comments

@fprochazka
Copy link
Collaborator

The less (and others) can @import other files, but webloader is watching only the root file. This means that the cache is not invalidate in such case.

@janmarek
Copy link
Owner

less directory can be watched insted of root file

@fprochazka
Copy link
Collaborator Author

That's not enough imho. I would preffer to parse the file and find all imports and watch those files.

@janmarek
Copy link
Owner

It is much simpler then parsing less files and I think it would be ok for most users. Gulp and grunt watch plugin works this way (user specifies paths and file path patterns where files to watch are located). Also watching for directories would be probably faster then parsing in most cases.

@fprochazka
Copy link
Collaborator Author

It would definitely be faster, but the files must be parsed anyway, and if lessphp would provide api with list of includes that it found while parsing the file, it would be ideal.

@JanTvrdik
Copy link
Contributor

lessc (#93) has --depends option.

@bckp bckp mentioned this issue Jun 8, 2015
@Ciki
Copy link
Contributor

Ciki commented Jun 8, 2015

what's the current status of this? anybody working on this? I noticed a PR #98 implementing watch which @janmarek mentioned as a possible solution for this..

@Jeriiii
Copy link

Jeriiii commented Aug 2, 2015

I've fixed an issue with dependent LESS files. Webloader now detects changes made in files imported using @import.
http://forum.nette.org/cs/2578-addon-webloader-extras-webloader?p=7#p160136

@fprochazka
Copy link
Collaborator Author

Initial support added in a5575b7. I'm not sure if this can be considered a final solution, but it should work nicely at least for simple use-cases.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

No branches or pull requests

5 participants