Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

bug: Docker container blasts config every time it start. #1861

Open
2 of 7 tasks
jagauthier opened this issue Jan 15, 2025 · 0 comments
Open
2 of 7 tasks

bug: Docker container blasts config every time it start. #1861

jagauthier opened this issue Jan 15, 2025 · 0 comments
Assignees
Labels
type: bug Something isn't working

Comments

@jagauthier
Copy link

Cortex version

All

Describe the issue and expected behaviour

I noticed after updating my cortex that my specific config changes kept getting removed. Including CORS, allowed hosts, hugging face model.

Steps to Reproduce

The issue is that in docker/entrypoint.sh the config file is ruined upon startup. The cortex fills in the rest with defaults.

echo "apiServerHost: 0.0.0.0" > /root/.cortexrc

Additionally, the config file is inside of the container, and using the provided documentation it will not survive across removal and recreation of the container:

Docs say:
docker run --gpus all -it -d --name cortex -v cortex_data:/root/cortexcpp -p 39281:39281 menloltd/cortex

However, the config is not in that folder, as evidenced by the running command:
cortex-server --ignore_cout --config_file_path /root/.cortexrc --data_folder_path /root/cortexcpp

So there are two problems here. 1) The instructions have the user create a container and the config is implied to be temporary, which it is not. If you make a config outside of the container and reference it with -v, the container start process overwrites the file when it starts.

Screenshots / Logs

No response

What is your OS?

  • Windows
  • Mac Silicon
  • Mac Intel
  • Linux / Ubuntu

What engine are you running?

  • cortex.llamacpp (default)
  • cortex.tensorrt-llm (Nvidia GPUs)
  • cortex.onnx (NPUs, DirectML)

Hardware Specs eg OS version, GPU

No response

@jagauthier jagauthier added the type: bug Something isn't working label Jan 15, 2025
@github-project-automation github-project-automation bot moved this to Investigating in Menlo Jan 15, 2025
@jagauthier jagauthier changed the title bug: [DESCRIPTION] Docker container blasts config every time it start. bug: Docker container blasts config every time it start. Jan 15, 2025
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
type: bug Something isn't working
Projects
Status: Investigating
Development

No branches or pull requests

3 participants