Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Refactor out core to support adapters to different versions of play/different libraries #597

Open
blast-hardcheese opened this issue Oct 16, 2016 · 4 comments

Comments

@blast-hardcheese
Copy link

Most IdentityProviders are self-contained, only depending on bits and pieces of Play.

I propose breaking out the self-contained parts of module-code out into a securesocial-core, then abstracting the bits of Play that are actually required (configuration, HTTP, caching, localization) into adapters that can bridge the gap from different versions of play (and different libraries entirely).

Given the recent 2.1.4-for-play24, it seems like this will become more important as Play continues to evolve, since specialized adapter code would be able to be defined in the consumer's project, the different versions of securesocial-core being versioned completely separate from Play.

This is just a proposal, I'm curious to see how many would be interested in something like this.

@jaliss
Copy link
Owner

jaliss commented Jan 25, 2017

@blast-hardcheese I thought of this several times and it was even proposed in the mailing list if I remember correctly. I need to wrap up the new version which is quite delayed and then see if/how this could be done.

@blast-hardcheese
Copy link
Author

blast-hardcheese commented Jan 27, 2017 via email

@jaliss
Copy link
Owner

jaliss commented Jan 27, 2017

@blast-hardcheese I would not include a refactoring like that at this point. There are other urgent things so this is really something for a future version.

@blast-hardcheese
Copy link
Author

blast-hardcheese commented Jan 27, 2017 via email

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

No branches or pull requests

2 participants